[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#722898: benchmarks



Hi

Thiemo Nagel <thiemo.nagel@gmail.com> writes:

> Hello Gaudenz,
>
> thank you for your email!
>
> Any reason why you choose 512k? If I understand your benchmarks right,
>> doubling this to 1M yelds about another 27% gain.
>
>
> I'm sorry, I forgot to mention that I've re-run the benchmarks. After
> removing O_SYNC, the performance was identical for block sizes in the range
> of 32k to 16M. I chose 512k (16 times larger than the lowest value that
> I've tested) with the intent to exclude a block size penalty for devices up
> to 16x faster than my md raid1 setup, which comes in at around 80MB/s.
>
> Except for low-memory installs, I'm not aware of any obstacle to increasing
> the buffer even more. (And of course, there's always the option to test for
> available memory and chose the buffer size depending on that.)
>
>
>> > #2    blockdev-wipe: Reduce progress indicator granularity to 1/1000
>>
>> This still sounds like a lot of granularity. IMO this could be reduced
>> to 1/100. Do we really need progress updates for less than 1%?
>>
>
> For a large device, wipe times still can be many hours. At a granularity of
> 1/1000, the progress indicator would advance every 10-50 seconds (order of
> magnitude), which I don't consider excessive. (Of course, this only holds
> true if the graphical frontend supports this kind of granularity, which I
> don't know.)

I don't know about the graphical frontend, but I'm pretty sure the console
based frontend is not able to display a finer granularity than 1/100.

If we are changing this anyway, maybe it's a good time to also make the
template partman-crypto/progress/erase a bit more explicit about
canceling.

It currently reads: "Erasing data on ${DEVICE}". Maybe something like 
"Erasing data on ${DEVICE}. To continue without ereasing press
'Cancel'." How do others feel about this? Several bug reports show that
it's apparently not clear to many users that they can cancel the
operation and what happens if they select cancel.

Gaudenz

-- 
Ever tried. Ever failed. No matter.
Try again. Fail again. Fail better.
~ Samuel Beckett ~


Reply to: