[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#707137: pu: package tasksel/3.14.1



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: pu

Unfortunately, wheezy shipped with a tasksel that, on a desktop system,
selects both the desktop and the ssh server tasks for installation by
default. This was not intentional. The intent was to default to
selecting the desktop task on desktop systems, and the ssh server task
on all other systems.

A typo in the code prevented this from working correctly, and apparently
I was the only one who was aware of how it was intended to work, and I
was not able to participate in testing wheezy installations prior to
release. I only learned of this issue on wheezy release day when
observing users mentioning that both tasks were selected.

This is not a good behavior to have in stable, because a user who is not
paying much attention can end up with a ssh server installed
unintentionally, and be vulnerable to automated password probes.
We can assume that users who are installing servers
a) intend to run ssh (or will notice and de-select it if not) and
b) can take responsibility for using it securely.
But not so for all desktop users.

I have uploaded tasksel to s-p-u with this patch. I recommend it be
included in the next point release.

diff --git a/debian/changelog b/debian/changelog
index 5e17347..2d20341 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+tasksel (3.14.1) stable; urgency=low
+
+  * Fix broken test for non-desktop systems which caused the ssh server task
+    to be selected by default on systems with a desktop.
+
+ -- Joey Hess <joeyh@debian.org>  Tue, 07 May 2013 13:57:43 -0400
+
 tasksel (3.14+nmu2) unstable; urgency=low
 
   * Downgrade network-manager-gnome from Depends to Recommends. It's
diff --git a/tests/server b/tests/server
index e8ca610..3aeff7c 100755
--- a/tests/server
+++ b/tests/server
@@ -1,7 +1,12 @@
 #!/bin/sh
+
+if ! [ "$NEW_INSTALL" ]; then
+	exit 3
+fi
+
 /usr/lib/tasksel/tests/desktop
 ret=$?
-case ret in
+case $ret in
 	0|2) # is desktop
 		exit 3 # not server
 	;;

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: