Re: [PATCH] grub-installer: Support menu selection of grub boot disk
On Wed, Apr 24, 2013 at 10:48:40AM +1000, Vincent McIntyre wrote:
> Support user selection of grub boot disk from a list of disks
> via a new question, grub-installer/choose_bootdev.
> Check for a mismatch between a preseeded value of grub-installer/bootdev
> and the guess at the default boot disk made by grub-installer,
> and prompt the user to choose the correct disk.
>
> This should help the user avoid grub-installer writing to the MBR
> of the wrong device (e.g. #696877) and fix the issue of preseeded
> values of bootdev being ignored (e.g. #666974).
>
> Signed-off-by: Vincent McIntyre <vincent.mcintyre@csiro.au>
> ---
> debian/grub-installer.templates | 16 +++++
> debian/po/templates.pot | 17 +++++
> grub-installer | 130 +++++++++++++++++++++++++++++++++++++--
> 3 files changed, 159 insertions(+), 4 deletions(-)
>
> diff --git a/debian/grub-installer.templates b/debian/grub-installer.templates
> index 888a656..5d15411 100644
> --- a/debian/grub-installer.templates
> +++ b/debian/grub-installer.templates
> @@ -86,6 +86,22 @@ _Description: Device for boot loader installation:
> drive;
> - "/dev/fd0" will install GRUB to a floppy.
>
> +Template: grub-installer/choose_bootdev
> +Type: select
> +Choices-C: ${CHOICES}
> +Choices: ${DESCRIPTIONS}
> +# :sl2:
> +_Description: Select disk for boot loader installation:
> + You need to make the newly installed system bootable, by installing
> + the GRUB boot loader on a bootable device. The usual way to do this is to
> + install GRUB on the master boot record of your first hard drive. If you
> + prefer, you can install GRUB elsewhere on the drive, or to another drive,
> + or even to a floppy.
> + .
> + Select a disk from the list. GRUB will be installed to the master boot
> + record of that disk. If you want to install GRUB somewhere other than the
> + master boot record of one of these disks, select 'Enter device manually'.
> +
> Template: grub-installer/password
> Type: password
> # :sl2:
The deb already has a question about which device to install too.
Wouldn't it be better to reuse that question? To use the same text and
the existing translations?
MfG
Goswin
Reply to: