[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#701814: Re: Bug#701814: os-prober: damages XFS exported via iSCSI but not mounted locally; potential data loss



Hi,

On 02/27/2013 05:28 PM, Torsten Jerzembeck wrote:
> Julien Cristau wrote:
>> On Wed, Feb 27, 2013 at 13:41:45 +0100, Torsten Jerzembeck wrote:
>>> Package: os-prober
>>> Version: 1.42
>>> Severity: grave
>>> Justification: causes non-serious data loss
>>>
>>> While updating the kernel on a storage server exporting a large XFS via
>>> iSCSI, os-prober tried to mount this file system. This operation disrupted
>>> the iSCSI operation and damaged the file system.
>>>
>> On that kind of machine you really want to set
>> GRUB_DISABLE_OS_PROBER=true in /etc/default/grub.
> Granted (and thanks for pointing me to that option which I didn't know
> about before this). However, I think os-prober shouldn't blindly mount
> seemingly unmounted filesystems. It should check at least if there is
> another process accessing that filesystem/device.

os-prober uses 'mount -o ro', or grub-mount from 1.45:

commit 7ed9dec4d2c65056f211324f8e25a4d913b0f2a1
Author: Colin Watson <cjwatson@debian.org>
Date:   Fri Apr 8 17:39:32 2011 +0100

    Use grub-mount if it exists.  This lets us do true read-only mounts,
and works better on journalling filesystems that were mounted uncleanly.

It does practically everything to avoid file system corruption thus I
think this bug should be either closed or moved to mount package to
provide a true read-only option if '-o ro'
is not enough.

Cheers,
Balint


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: