[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#663540: finds MSDOS when there is none



On Mon, Mar 12, 2012 at 11:14:07AM -0400, Joey Hess wrote:
> These checks don't try to avoid false positives like a /dos or /windows,
> because the code earlier checks that the mounted filesystem is one of ntfs,
> vfat, or msdos. To which list was semi-recently added fuse, and I suspect
> that might be the root of the problem. 
> 
> Colin, if grub-mount is being used, will *every* filesystem appear as fuse?
> If so, this and other code has become much more prone to false positives
> than it was when it was originally written.

Hm, probably, yes.  (To some extent, you get to pick which kind of
fragility you want.)

How about, if grub-mount is used, we use grub-probe to find out which
GRUB filesystem driver is in use, and stash that somewhere so that
individual tests can get at it?  That ought to be just as reliable as
the existing OS filesystem type checks.

-- 
Colin Watson                                       [cjwatson@debian.org]



Reply to: