Bug#696968: rootskel-gtk: theme=dark results in ever-looping X

[Cyril Brulebois <kibi@debian.org>]

Package: rootskel-gtk
Version: 1.26
Severity: important
Tags: d-i

Hi folks,

adding theme=dark to the command line for accessibility purposes leads
to an ever-looping X. Basically, options for the X server (see
rootskel-gtk's S62Xorg) lead to its termination after a first client
exited, and that's what's happening when the theme is set (S65theme).

Switching -terminate and -noreset fixes that (but see the manpage…).
Looks like we need to review those options.

Regression from (ironically for accessibility purposes ;)):
| commit 46997e8b58a1076a9293382379c17377730395b7
| Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
| Date:   Tue Jul 26 23:39:34 2011 +0200
| 
|     Pass -terminate option to X server, so that brltty can nicely kill debconf and see Xorg terminate as a consequence.
| 
| diff --git a/debian/changelog b/debian/changelog
| index 4b58b58..55cc0cd 100644
| --- a/debian/changelog
| +++ b/debian/changelog
| @@ -1,3 +1,11 @@
| +rootskel-gtk (1.23) UNRELEASED; urgency=low
| +
| +  [ Samuel Thibault ]
| +  * Pass -terminate option to X server, so that brltty can nicely kill debconf
| +    and see Xorg terminate as a consequence.
| +
| + -- Samuel Thibault <sthibault@debian.org>  Tue, 26 Jul 2011 23:37:47 +0200
| +
|  rootskel-gtk (1.22) unstable; urgency=low
|  
|    [ Miguel Figueiredo ]
| diff --git a/src/lib/debian-installer.d/S62Xorg b/src/lib/debian-installer.d/S62Xorg
| index 37ace7c..83d15c8 100644
| --- a/src/lib/debian-installer.d/S62Xorg
| +++ b/src/lib/debian-installer.d/S62Xorg
| @@ -1,6 +1,6 @@
|  if [ "$DEBIAN_FRONTEND" = gtk ] && [ -z "$LIVE_INSTALLER_MODE" ]; then
|         trap : SIGUSR1
| -       (trap '' SIGUSR1; exec Xorg -noreset -nolisten tcp) &
| +       (trap '' SIGUSR1; exec Xorg -noreset -nolisten tcp -terminate) &
|         wait
|         export DISPLAY=:0
|  fi

Mraw,
KiBi.