[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#696903: [1.83->1.84 regression]: GRUB won't install to a character device



Control: tags -1 + patch

Allow installing GRUB to a character device, as on GNU/kFreeBSD

diff --git a/grub-installer b/grub-installer
index 5d9fd77..6e2c7fc 100755
--- a/grub-installer
+++ b/grub-installer
@@ -651,9 +651,9 @@ if [ -z "$frdisk" ]; then
        # Install grub on each space separated disk in the list
        bootdevs="$bootdev"
        for bootdev in $bootdevs; do
                # workaround for #681227
-               if [ ! -b $bootdev -a $bootdev != dummy ]; then
+               if [ ! -b $bootdev -a ! -c $bootdev -a $bootdev != dummy ]; then
                        continue
                fi
                grub_install_params=
                if ! is_floppy "$bootdev"; then


Or instead - make the logical IMHO clearer, and while here, wrap
$bootdev in quotes to be paranoid:

diff --git a/grub-installer b/grub-installer
index 5d9fd77..552c9bc 100755
--- a/grub-installer
+++ b/grub-installer
@@ -651,9 +651,9 @@ if [ -z "$frdisk" ]; then
        # Install grub on each space separated disk in the list
        bootdevs="$bootdev"
        for bootdev in $bootdevs; do
                # workaround for #681227
-               if [ ! -b $bootdev -a $bootdev != dummy ]; then
+               if ! [ "$bootdev" = dummy -o -b "$bootdev" -o -c "$bootdev" ]; then
                        continue
                fi
                grub_install_params=
                if ! is_floppy "$bootdev"; then


Thanks,
Regards,
-- 
Steven Chamberlain
steven@pyro.eu.org


Reply to: