[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#686502: pxz produces archives broken for busybox's unxz



Abou Al Montacir wrote:
> On Sat, 2012-12-22 at 10:21 -0800, Jonathan Nieder wrote:

>> What happens if a stream ends at a buffer boundary, followed by
>> padding?  Or if padding doesn't fit in the buffer, for that
>> matter?
[...]
> Please find attached new debdiff with fix of above mentioned issues.

Getting closer.  Does this correctly handle the case of a file with
zero streams?  (It should error out.)  How about a file with leading
NUL bytes, which is also invalid?

Does this implementation meet the following requirement (from the
spec)?

| Stream Padding MUST contain only null bytes. To preserve the
| four-byte alignment of consecutive Streams, the size of Stream
| Padding MUST be a multiple of four bytes. Empty Stream Padding
| is allowed. If these requirements are not met, the decoder MUST
| indicate an error.

Thanks for your patient work.
Jonathan


Reply to: