Control: reassign -1 debconf Control: found -1 1.5.46 Control: found -1 1.5.48 Control: tag -1 d-i (Older versions are also affected, but I'm making sure at least wheezy/sid versions are marked properly.) Cyril Brulebois <kibi@debian.org> (27/06/2012): > Package: debian-installer > Version: 20120626 > Severity: important > > I thought it was fixed in squeeze's release cycle, but apparently > not. Seen with graphical install, on i386, with the above-mentioned > image, but also with squeeze's business card. > > When reaching grub prompts, the title says “Configuring man-db” > (even though it's properly localized). Might be some issue on the > debconf side, I didn't look at it yet. So, finally tracked it down, confirming my initial suspicion: the triggers are doing that. Basically, we have debconf in target setting titles through the frontend script, even when maintainer scripts are called with the “triggered” action. I'm suggesting the attached patch, avoiding setting the title in that specific case. That doesn't affect debconf-apt-progress feedback: one still sees triggers being processed (and that's good since they can take a while). Confirmed by partial-cloning an archive, hacking hashsums and keyrings in place, and installing with that… [*crazy evening*] Does that look fine enough? If so, a quick upload to get that fixed in testing before publishing d-i wheezy rc1 would be nice. (I'll be replying to the debconf 1.5.48 unblock request in the meanwhile.) Mraw, KiBi.
From d35ded25cff7be1c709348505713f0fee7d0ce1e Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <kibi@debian.org>
Date: Fri, 21 Dec 2012 21:36:54 +0100
Subject: [PATCH] =?UTF-8?q?frontend:=20Stop=20emitting=20title=20updates=20w?=
=?UTF-8?q?ith=20=E2=80=9Ctriggered=E2=80=9D=20actions=20in=20maintainer=20s?=
=?UTF-8?q?cripts.=20Closes:=20#679327?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
debian/changelog | 9 +++++++++
frontend | 6 +++++-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/debian/changelog b/debian/changelog
index 2e20c5e..958e8e7 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+debconf (1.5.49) UNRELEASED; urgency=low
+
+ * frontend: Don't set title in the maintainer script case when the
+ action is “triggered”. This totally confuses the Debian Installer
+ (“Configuring man-db” instead of “Configuring grub-pc”, notably).
+ Closes: #679327
+
+ -- Cyril Brulebois <kibi@debian.org> Fri, 21 Dec 2012 21:34:01 +0100
+
debconf (1.5.48) unstable; urgency=low
* dpkg-reconfigure: Fix incorrect scoping of control_path that broke
diff --git a/frontend b/frontend
index 83a3967..690bedc 100755
--- a/frontend
+++ b/frontend
@@ -34,11 +34,15 @@ shift @ARGV if $ARGV[0] eq '--';
# Set the default title.
my $package;
+my $no_title=0;
if ($ENV{DEBCONF_PACKAGE}) {
$package=$ENV{DEBCONF_PACKAGE};
}
elsif ($ARGV[0]=~m!^.*/(.*?)\.(?:postinst|postrm|prerm)$!) {
$package=$1;
+ my $action=$ARGV[1];
+ # Avoid spurious title updates with triggered actions:
+ $no_title=1 if $action eq 'triggered';
}
elsif (-e "/var/lib/dpkg/tmp.ci/control") {
# The preinst is running, presumably. Now it gets really ugly, because
@@ -89,7 +93,7 @@ else {
}
}
debug developer => "frontend running, package name is $package";
-$frontend->default_title($package) if length $package;
+$frontend->default_title($package) if length $package and !$no_title;
$frontend->info(undef);
# See if the preinst or postinst of the package is being run, and if there
--
1.7.10.4
Attachment:
signature.asc
Description: Digital signature