21.12.2012 17:06, Abou Al Montacir wrote:
On Thu, 2012-12-20 at 23:08 +0100, Bastian Blank wrote:On Thu, Dec 20, 2012 at 10:42:41PM +0100, Abou Al Montacir wrote:Can you please test the attached patchHow does it implement stream padding?Hi Bastian, As it is implemented, it will iterate until end of stream, but I did not test this particular case.
Actually it is not:
+ if (iobuf.in_pos == iobuf.in_size) {
+ break;
+ } else {
iobuf is what we've in memory. We may've read some data which
ends in buffer exactly at the end of the stream. There might
be next stream coming, but for it we may need to read a few
more bytes first... At least if I read the code correctly.
It is sorta like testing if we reached end of file by testing
whenever we're at the end of stdio buffer.
Thanks,
/mjt