Bug#652946: partman-target should not create /var/run
On Thu, 12 Jul 2012, Michael Tokarev wrote:
> This whole hack is not needed anymore, and /run will
> be created in a usual way during install process.
>
> So this whole trick should be removed.
I agree. Here's the corresponding patch. It would be nice if someone
could commit it so that it gets included in the next d-i release.
It's needed to have a proper live image for wheezy.
Cheers,
--
Raphaël Hertzog ◈ Debian Developer
Get the Debian Administrator's Handbook:
→ http://debian-handbook.info/get/
>From a91bb071ba7b011045aa83d17c6018c311485f51 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rapha=C3=ABl=20Hertzog?= <hertzog@debian.org>
Date: Thu, 6 Dec 2012 16:51:15 +0100
Subject: [PATCH] Do not create /var/run and /var/lock directories in /target
Nowadays those are supposed to be symlinks and their existence hurts more
than helps. In particular, it breaks live-installer which uses tar
to extract the content of the live system over /target. At least busybox's
tar fails to extract a symlink over a pre-existing directory.
Thanks to Rui Bernardo and Michael Tokarev for the investigations.
Closes: #652946
---
debian/changelog | 9 +++++++++
finish.d/mount_partitions | 8 --------
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index ec24040..bcb7ef1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+partman-target (81) UNRELEASED; urgency=low
+
+ * Do not create /var/run and /var/lock directories in /target. Nowadays
+ those are supposed to be symlinks and their existence hurts more than
+ helps. Closes: #652946
+ Thanks to Rui Bernardo and Michael Tokarev for the investigations.
+
+ -- Raphaël Hertzog <hertzog@debian.org> Thu, 06 Dec 2012 16:45:54 +0100
+
partman-target (80) unstable; urgency=low
[ Updated translations ]
diff --git a/finish.d/mount_partitions b/finish.d/mount_partitions
index 9c8499e..8dcbb8a 100755
--- a/finish.d/mount_partitions
+++ b/finish.d/mount_partitions
@@ -58,14 +58,6 @@ for f in $fstab; do
# needed to unmount the partition; currently this is unused
unmount_cmd=$($m "$f")
if [ "$?" = 0 ]; then
- case $2 in
- /)
- # Create these before /var is mounted,
- # so that they can be mounted as tmpfses
- mkdir -p /target/var/lock
- mkdir -p /target/var/run
- ;;
- esac
continue 2
fi
done
--
1.7.10.4
Reply to: