[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#674894: preseeding: Partitions are not aligned when forcing GPT



I reopened this bug, because I would like this bug to be fixed in
a point-release of squeeze. If that is not possible or against
policy, feel free to close this bug. Otherwise I ask that, if in
a pointrelease an updated installer is shipped, you consider
adding this patch to partman-base.

Thank you

partman-base-147-align-gpt.patch

--- partman-base/parted_server.c	2010-10-04 22:16:53.000000000 +0200
+++ partman-base-158/parted_server.c	2012-07-02 14:57:03.000000000 +0200
@@ -1,6 +1,7 @@
 #include <parted/parted.h>
 #include <sys/types.h>
 #include <sys/wait.h>
+#include <sys/stat.h>
 #include <unistd.h>
 #include <stdio.h>
 #include <string.h>
@@ -608,10 +609,16 @@
                         ped_disk_set_flag(disk, PED_DISK_CYLINDER_ALIGNMENT,
                                           devices[index].alignment ==
                                                 ALIGNMENT_CYLINDER);
-                else
+                else if (0 != strcmp(disk->type->name, "gpt"))
                         /* If the PED_DISK_CYLINDER_ALIGNMENT flag isn't
-                           available, then (confusingly) we should assume
-                           that *only* cylinder alignment is available. */
+                           available, then there are two alternatives:
+                           either the disk label format is too old to know
+                           about modern alignment (#579948), or it's too new
+                           to care about cylinder alignment (#674894).  The
+                           only format currently known to fall into the
+                           latter category is GPT; for the others, we should
+                           assume that *only* cylinder alignment is
+                           available. */
                         devices[index].alignment = ALIGNMENT_CYLINDER;
         }
 }


Reply to: