[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#670993: busybox: Please use dpkg-buildflags for hardening support



On Tue, May 01, 2012 at 09:53:14AM +0400, Michael Tokarev wrote:
> On 01.05.2012 08:23, Steve Langasek wrote:
> > +CFLAGS := $(filter-out -Werror=format-security,$(CFLAGS))

> Why do you filter this -W option?

Well, it causes a build failure if you don't. ;)  I inherited this from the
previous Ubuntu changes, so I haven't fully reviewed the reason for this
change but I believe they're all in the category of things that are safe but
that gcc can't prove are safe.

> Also, I'd rather use EXTRA_CFLAGS not CFLAGS alone, or
> the other way around (allowing EXTRA_CFLAGS), but I'll
> have to check.

Ok.

Cheers,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                    http://www.debian.org/
slangasek@ubuntu.com                                     vorlon@debian.org

Attachment: signature.asc
Description: Digital signature


Reply to: