[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#650159: busybox: Please set CONFIG_DEFAULT_MODULES_DIR and CONFIG_DEFAULT_DEPMOD_FILE to the appropriate defaults



On 27.11.2011 21:31, Jens Stimpfle wrote:
> Hello Michael,
> 
> On Sun, Nov 27, 2011 at 02:45:58PM +0400, Michael Tokarev wrote:
>> On 27.11.2011 08:25, Jens Stimpfle wrote:
>>> The default config has CONFIG_DEFAULT_MODULES_DIR and
>>> CONFIG_DEFAULT_DEPMOD_FILE set to empty strings (in
>>> /debian/config/pkg/{deb,static}) to enable automatic build process. They
>>> should be rather set to "/lib/modules", respectively "modules.dep",
>>> which are the defaults when asked to define them while building with
>>> them not defined.
>>>
>>> This seems to not affect the package itself because those symbols are
>>> only used below modutils/ dir which does not build objects in the
>>> default configuration. But rebuilding the package with modutils enabled
>>> currently yields defunct modprobe / depmod executables for instance.
>>
>> These symbols can not be defined without enabling module utils, which
>> are not enabled.
> 
> I think you got me wrong. They /are/ defined, albeit to "" (see
> debian/config/pkg/{deb,static}). Only they are not defined suitably to
> build working modutils, whilst the definition value does not seem to
> affect the current package (not building modutils) by any means. So I
> don't see the point in deviating from upstream's defaults.

Try defining these values in config and _not_ enable module utils,
and run `make oldconfig'.  The values of these variables will be
reset back to empty strings.  That's what I mean by saying it is
impossible to set - they will be reset by the build system, and
it is impractical to remember to change them back each time I
update the config, especially since this feature is not used
at all.

If you want to build different busybox, just do it, and redefine
any config symbols you like, including these ones.

Besides, I plan to enable module utils soon, with these values
being set properly.

Thanks,

/mjt



Reply to: