Re: [SCM] d-i finish-install repository branch, master, updated. 2.28-15-gb0325e8
On Thu, May 26, 2011 at 06:41:30PM +0200, Christian PERRIER wrote:
> Quoting Colin Watson (cjwatson@debian.org):
> > The following commit has been merged in the master branch:
> > commit b0325e8e80272cfc71c3004f9e0f53f681b0cc74
> > Author: Colin Watson <cjwatson@debian.org>
> > Date: Thu May 26 15:26:30 2011 +0100
> >
> > Clean up the contents of /run just before unmounting /target, to avoid cruft in the target system. (Alternatives such as mounting a tmpfs there during installation proved to be too complicated and/or fragile.)
>
> > +umount /target/run 2>/dev/null || true
> > +rm -rf /target/run/*
> > +
> > umount -a || true
>
> Just thinking out loud: isn't there a chance that some dotfiles (or
> dotirs) end up in /run on the installed system...thus leaving us with
> still some cruft left after the above?
Yes. I tested and found that this wasn't currently the case; I imagine
we can always amend if it turns out to be so later.
I suspect dotfiles/dotdirs are less likely now that people aren't having
to hide these kinds of directories inside /dev; the current trend for
entries in /run seems to be to just leave them out in the open since
there's no real reason not to.
Cheers,
--
Colin Watson [cjwatson@debian.org]
Reply to: