[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#613277: marked as done (anna: [DACA] popen+fclose should be popen+pclose)

Your message dated Fri, 22 Apr 2011 21:02:10 +0000
with message-id <E1QDNUQ-0005ro-21@franck.debian.org>
and subject line Bug#613277: fixed in anna 1.40
has caused the Debian Bug report #613277,
regarding anna: [DACA] popen+fclose should be popen+pclose
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
613277: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613277
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: anna
Version 1.39
Severity: minor
Tag: patch

DACA reports a mismatching allocation and deallocation in util.c:

  http://qa.debian.org/daca/cppcheck/sid/anna_1.39.html

Right, popen should be used together with pclose.

Patch attached.


--- anna-1.39/util.c.orig	2009-07-23 19:43:25.000000000 +0200
+++ anna-1.39/util.c	2011-02-13 21:35:34.548412831 +0100
@@ -208,13 +208,13 @@
 	if (fp == NULL)
 		return 0;
 	if (fgets(line, sizeof(line), fp) != NULL) {
-		fclose(fp);
+		pclose(fp);
 		if (strlen(line) < 32)
 			return 0;
 		line[32] = '\0';
 		return !strcmp(line, sum);
 	}
-	fclose(fp);
+	pclose(fp);
 	return 0;
 }
 

-- 
CYa,
  ⡍⠁⠗⠊⠕

--- End Message ---
--- Begin Message --- 
Source: anna
Source-Version: 1.40

We believe that the bug you reported is fixed in the latest version of
anna, which is due to be installed in the Debian FTP archive:

anna_1.40.dsc
  to main/a/anna/anna_1.40.dsc
anna_1.40.tar.gz
  to main/a/anna/anna_1.40.tar.gz
anna_1.40_i386.udeb
  to main/a/anna/anna_1.40_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 613277@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated anna package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Fri, 22 Apr 2011 22:10:37 +0200
Source: anna
Binary: anna
Architecture: source i386
Version: 1.40
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description: 
 anna       - anna's not nearly apt, but for the Debian installer, it will do (udeb)
Closes: 613277
Changes: 
 anna (1.40) unstable; urgency=low
 .
   * Team upload
 .
   [ Joey Hess ]
   * Fix use of pclose for popened handles. Closes: #613277
 .
   [ Updated translations ]
   * Bulgarian (bg.po) by Damyan Ivanov
   * Czech (cs.po) by Miroslav Kure
   * Esperanto (eo.po) by Felipe Castro
   * Spanish (es.po) by Javier Fernández-Sanguino
   * Estonian (et.po) by Mattias Põldaru
   * Korean (ko.po) by Changwoo Ryu
   * Romanian (ro.po) by Eddy Petrișor
   * Slovak (sk.po) by Ivan Masár
   * Swedish (sv.po) by Daniel Nylander
   * Thai (th.po) by Theppitak Karoonboonyanan
   * Uighur (ug.po) by Sahran
Checksums-Sha1: 
 78d52930a8dc3c5deddaf123cceefd9b4b91f51b 1536 anna_1.40.dsc
 6c6201a8ed4742f1b25fa10a64b0b5371d76d2cc 97932 anna_1.40.tar.gz
 da66035f6977d2980b8d2d5d20013a4b70324e01 71518 anna_1.40_i386.udeb
Checksums-Sha256: 
 22e075da8d3f9a9dd51c49f62a39e38067de0d83a1e0f3ca9594ed2efe7feb2b 1536 anna_1.40.dsc
 dc878d02403c09029b03f4601727892c5ae808f4c9ea0853cab25436705461d5 97932 anna_1.40.tar.gz
 0de44e6763e4dc3143e2e655472d4e8efbe2f561b1a11906cd97e9250008652f 71518 anna_1.40_i386.udeb
Files: 
 cd49ced8be6b36f1aca46cf782b9726a 1536 debian-installer standard anna_1.40.dsc
 4bb6c5d0fa4bb6a0806e5f8df1939bef 97932 debian-installer standard anna_1.40.tar.gz
 0ff796e5b69f333603006d6435b6f187 71518 debian-installer standard anna_1.40_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIVAwUBTbHi/4cvcCxNbiWoAQI4kw/9G/TOOCoRclDpbmDlizzVKTkQaJC2fM39
Cwu/UBmDaMAgzf0PQOPdn153zd5P8PGJyRvgAjl0mtpxV4CDM6oH8cggoAgqzbZ+
JLJ341JggO498NVVdfBNFCmMJY1m4KAQyp4Ms0uW9ZyP9Smu5+Ma/aCAfHqWMmWm
5qNKky7pkepUMoyv5NZBZbW1rEm0lcFLH+CJ/erv7eZ7f7WSK4G7gskOnVHusbgT
/I1tSz+O9BGfAA2a6uhpU5xGLxDfmK4PRenI+MJaJYOlk88Irh51PXkOiNmt/PS9
Ze9HewPOzHSSAS3DodQbkrTdNa/Qn/u0Pd8Ctm503tYOQDTbwFs0fhjjkJWZx6Y2
AOuetr+hX2ozyzWYElSDnpK0pcGSk7nhnshH6jI6uqzqT/8lp3+DW793hc8eokeT
UjdrPG6fQItm5CMMMsDQd1MLSWIZ8rfKKMF/5Hrn8WmB1c3cmjKI0ioTh7FkXww2
PP95Jj3FA+y8MLMerBV4a1YbBoG5sMYfuehEKQvASH4Rh+pHWCR1l3dn9J99UNqf
iCP+YtgKvAXKmlOzJeyDgtq7Eo3uGWQpqNBbwOs3bDslGkMcnNHW1ADUchVJlHQ2
NUJoyRN+qp6kISqxOF7dPPatbA/slD3ooW5jPtBfwXE+NpzwciOWU3sS54W6Oisw
7gZcLYCZDG8=
=tuh3
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: