[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#616605: marked as done ('Execute shell in <installation>' runs /bin/sh not /bin/bash)



Your message dated Fri, 08 Apr 2011 12:32:39 +0000
with message-id <E1Q8Arf-00031K-SV@franck.debian.org>
and subject line Bug#616605: fixed in rescue 1.27
has caused the Debian Bug report #616605,
regarding 'Execute shell in <installation>' runs /bin/sh not /bin/bash
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
616605: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=616605
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: rescue-mode
Version: 1.26
Severity: important
Tags: patch

Since /bin/sh is now linked to dash by default, /bin/sh is a poor
choice for an interactive shell.  Not everyone will think to use
'exec bash', so try bash first.

Ben.

-- System Information:
Debian Release: wheezy/sid
  APT prefers oldstable-proposed-updates
  APT policy: (500, 'oldstable-proposed-updates'), (500, 'unstable'), (1, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 2.6.37-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 0fdf6b422191121f46c9fd011bea5ea10c2265c2 Mon Sep 17 00:00:00 2001
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sat, 5 Mar 2011 22:36:13 +0000
Subject: [PATCH] rescue-mode: Try executing bash before /bin/sh

Since /bin/sh is now linked to dash by default, /bin/sh is a poor
choice for an interactive shell.  Not everyone will think to use
'exec bash', so try bash first.
---
 rescue.d/shell |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/rescue.d/shell b/rescue.d/shell
index ae67c82..785f260 100755
--- a/rescue.d/shell
+++ b/rescue.d/shell
@@ -32,7 +32,9 @@ shell_failed () {
 	db_capb backup
 }
 
-if [ -f /target/bin/sh ] && [ -x /target/bin/sh ]; then
+if chroot_has bash; then
+	chroot_run 'bash -i' || shell_failed 'bash -i'
+elif [ -f /target/bin/sh ] && [ -x /target/bin/sh ]; then
 	chroot_run /bin/sh -i || shell_failed '/bin/sh -i'
 elif chroot_has sash; then
 	chroot_run sash || shell_failed sash
-- 
1.7.4.1


--- End Message ---
--- Begin Message ---
Source: rescue
Source-Version: 1.27

We believe that the bug you reported is fixed in the latest version of
rescue, which is due to be installed in the Debian FTP archive:

rescue-check_1.27_all.udeb
  to main/r/rescue/rescue-check_1.27_all.udeb
rescue-mode_1.27_all.udeb
  to main/r/rescue/rescue-mode_1.27_all.udeb
rescue_1.27.dsc
  to main/r/rescue/rescue_1.27.dsc
rescue_1.27.tar.gz
  to main/r/rescue/rescue_1.27.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 616605@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated rescue package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 08 Apr 2011 13:19:06 +0100
Source: rescue
Binary: rescue-check rescue-mode
Architecture: source all
Version: 1.27
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description: 
 rescue-check - enter d-i rescue mode if requested (udeb)
 rescue-mode - mount requested partition and start a rescue shell (udeb)
Closes: 616605
Changes: 
 rescue (1.27) unstable; urgency=low
 .
   [ Otavio Salvador ]
   * Apply patch from Ben Hutchings to try /bin/bash before /bin/sh.
     Closes: #616605.
 .
   [ Colin Watson ]
   * Add btrfs to the list of filesystem modules to load.
 .
   [ Updated translations ]
   * Bulgarian (bg.po) by Damyan Ivanov
   * Czech (cs.po) by Miroslav Kure
   * Esperanto (eo.po) by Felipe Castro
   * Spanish (es.po) by Javier Fernández-Sanguino
   * Georgian (ka.po) by Aiet Kolkhi
   * Korean (ko.po) by Changwoo Ryu
   * Nepali (ne.po)
   * Romanian (ro.po) by Eddy Petrișor
   * Northern Sami (se.po) by Børre Gaup
   * Slovak (sk.po) by Ivan Masár
   * Swedish (sv.po) by Daniel Nylander
   * Telugu (te.po) by Arjuna Rao Chavala
   * Thai (th.po) by Theppitak Karoonboonyanan
Checksums-Sha1: 
 43817e8e8cb9f235b3efb1105339f00afeac243f 1557 rescue_1.27.dsc
 b0a1d660897ae57b293dbfd13e1aa033e71d0a25 136419 rescue_1.27.tar.gz
 8c24a7eda35682f17232ea76d3fa93aa89f33bf2 2478 rescue-check_1.27_all.udeb
 d2dab4e065dd23cbaa45b51833d92b1d960abea7 125646 rescue-mode_1.27_all.udeb
Checksums-Sha256: 
 09abf84012e5c64f3387f987e17fbf0641ec0dc3a3e3546ac203d8beae1a7972 1557 rescue_1.27.dsc
 083b19f4451d23c7455d842869fd1146505ed17c16700c7c83f21a49496d011b 136419 rescue_1.27.tar.gz
 d95a01d35492ab94a3ea8a546bb1b308af3fa6f83afd27b5a946577e5f7c4f92 2478 rescue-check_1.27_all.udeb
 e66c52db5582dbc3df99e12f39c9d557d50a140dfdf2799ed2e9adb5a1445f42 125646 rescue-mode_1.27_all.udeb
Files: 
 46a0376961c0ffc68ddce31cc40e0574 1557 debian-installer optional rescue_1.27.dsc
 545f5fe66825050bd1bbac3dbcde84b0 136419 debian-installer optional rescue_1.27.tar.gz
 ea6e153a5a66b0098e857f0b727bfb64 2478 debian-installer standard rescue-check_1.27_all.udeb
 7b18010982ab095625f686c3e20146b6 125646 debian-installer optional rescue-mode_1.27_all.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIVAwUBTZ79ZTk1h9l9hlALAQh9zA/+IdNu+9mD8YxE3J8JNFzZ6pnPO5mV7gta
Y3tBZD6oUMSMWl3zA2qhvxc7aVgEw03VSz9bSRZ4p30rr7+0wUBci18JUksEJ6i6
TKUh/KVXu8kFIbktSYD/QA8etEtrqkM0GdapKWbQrBwslBEszKOwallo5aLjDmmi
GsGI01fv+ldzhXOwUV5Od1CIa0Zl658Vd/qMwD5BlOsaaMZit+dFT/Y+pLVwuNLw
Z9WoEKStD9b1+afajuYYVgy+/hjwPVgIpHEu+PjP6gSxVLQbbepdprSl3bhkJf2v
p3UzEBV+NR5T/Vb57q0OopVlJ59KHYPHBacGgid1MaiwtWKZDeobkxblDQUGRUXS
s+9mHT+BHmTfg7HHO6pvWy4RvmtCica0+0snIWcYrzjo/ZEun98LRInPoxHfbieZ
CtwqE+LJKaLNqAaHB0KrXrtuLY1iDU+0MwGDrZ+OiJtLyct8fuQwJeFCX2YshHrR
yjBUETX4hSFnZ1clC7YngFWWdRbLUzfjxacHXdRcEzItotbvxPItwd5UfBaMThqA
GgFCGvN1fMVhQTeZSUL8eQGQzVIufgAnbsYEAOdy2kohupH5Vf3Nc+rDMpHzL4Ba
/gs/uTtcKcrK7OVwd7GaYRnAD68UhNO2LsOvW6IgbEziJvaBZfrjUpjZ39g+QTv7
ZqUFCiDCjag=
=xhUG
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: