[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#402127: marked as done (GTK frontend should build on and X target too)

Your message dated Mon, 21 Nov 2011 12:57:32 +0100
with message-id <1ec7b30e81c6f8842234d395069e958b@imalip.net>
and subject line cdebconf now uses X11
has caused the Debian Bug report #402127,
regarding GTK frontend should build on and X target too
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
402127: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=402127
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
package: cdebconf-gtk-udeb
severity: minor
tags: patch
This patch is needed to build cdebconf's GTK frontend in an X11 environment; i'm using GDK_WINDOWING_X11 as GDK_WINDOWING_DIRECTFB is currently not available in GTKDFB 2.8.20. 
I'd like this patch to be applied because
- It's necessary if one wants to replace debconf with cdebconf on a regular debian system (it's a blocker for #328498) 

-It's useful to test the GTK frontend on top of X11
I guess we'll also have to provide cdebconf's build system with a switch that allows building the directfb or x11 flavuor of the GTK frontend. 

Loic, could you please check if this patch is ok?

thanks

Attilio


Index: gtk.c
===================================================================
--- gtk.c	(revisione 43216)
+++ gtk.c	(copia locale)
@@ -49,13 +49,9 @@
 #include <debian-installer/slist.h>
 #include <gdk/gdkkeysyms.h>
 
-#if GTK_CHECK_VERSION(2,10,0)
-#ifdef GDK_WINDOWING_DIRECTFB
+#ifndef GDK_WINDOWING_X11
 #include <directfb.h>
 #endif
-#else
-#include <directfb.h>
-#endif
 
 #define WINDOW_WIDTH 800
 #define WINDOW_HEIGHT 600
@@ -1494,13 +1490,9 @@
      * (See also bug #381979)
      */
 
-    #if GTK_CHECK_VERSION(2,10,0)
-    #ifdef GDK_WINDOWING_DIRECTFB
+    #ifndef GDK_WINDOWING_X11
     dfb_input_device_reload_keymap( dfb_input_device_at( DIDID_KEYBOARD ) );
     #endif
-    #else
-    dfb_input_device_reload_keymap( dfb_input_device_at( DIDID_KEYBOARD ) );
-    #endif
 
     gtk_rc_reparse_all();

--- End Message ---
--- Begin Message --- 
Version: 0.149

Since cdebconf-gtk-udeb has been switched to using the X11 backend
with version 0.149, it is probably safe to consider the bug entitled
"GTK frontend should build on and X target too" fixed, so I'm closing
it.

If you believe I got it wrong, please do not hesitate to reopen it.

Regis

--- End Message ---
Reply to: