[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#634076: marked as done (cdebconf: [text] Should use commas to separate choices for proper speech synthesis)

Your message dated Sun, 20 Nov 2011 15:17:17 +0000
with message-id <E1RS98v-0000Ez-2u@franck.debian.org>
and subject line Bug#634076: fixed in cdebconf 0.158
has caused the Debian Bug report #634076,
regarding cdebconf: [text] Should use commas to separate choices for proper speech synthesis
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
634076: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=634076
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: cdebconf
Version: 0.156
Severity: normal
Tags: patch

Hello,

Currently, the speech synthesis speaks cdebconf choices in a
non-intelligible way. This is because:

1. Foo 2. Bar

is recognized as "1", then "Foo 2", then "Bar".

The attached patch fixes it by properly using colon and comma to
separate choices:

1: Foo, 2: Bar

the speech synthesis will then properly pause between "Foo" and "2".

Samuel

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.39-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages cdebconf depends on:
ii  debconf                      1.5.40      Debian configuration management sy
ii  dpkg                         1.16.0.3    Debian package management system
ii  libc6                        2.13-7      Embedded GNU C Library: Shared lib
ii  libdebian-installer4         0.78        Library of common debian-installer
ii  libnewt0.52                  0.52.11-2.1 Not Erik's Windowing Toolkit - tex
ii  libslang2                    2.2.4-2     S-Lang programming library - runti
ii  libtextwrap1                 0.1-12      text-wrapping library with i18n - 

cdebconf recommends no packages.

Versions of packages cdebconf suggests:
pn  cdebconf-gtk                  <none>     (no description available)

-- no debconf information

-- 
Samuel Thibault <samuel.thibault@fnac.net>
Actually, typing random strings in the Finder does the equivalent of
filename completion.
(Discussion in comp.os.linux.misc on the intuitiveness of commands: file
completion vs. the Mac Finder.)

diff --git a/src/modules/frontend/text/text.c b/src/modules/frontend/text/text.c
index db4988d..1e66244 100644
--- a/src/modules/frontend/text/text.c
+++ b/src/modules/frontend/text/text.c
@@ -234,10 +234,11 @@ printlist (struct frontend *obj, struct question *q, int count, char **choices_t
 	for (i=0; i < count; i++)
 	{
 		/*  Trailing spaces are a placeholder to add [*] for
-		    selected values */
-		asprintf(&(fchoices[i]), "%3d. %s    ", i+1, choices_translated[i]);
+		    selected values
+		    Comma is needed for proper speech synthesis pause */
+		asprintf(&(fchoices[i]), "%3d: %s,    ", i+1, choices_translated[i]);
 		if (selected[tindex[i]])
-			strcpy(fchoices[i]+strlen(fchoices[i])-3, "[*]");
+			strcpy(fchoices[i]+strlen(fchoices[i])-5, " [*],");
 		if (strwidth(fchoices[i]) < choice_min || choice_min == -1)
 			choice_min = strwidth(fchoices[i]);
 		if (strwidth(fchoices[i]) > width)
@@ -339,8 +340,8 @@ static int text_handler_boolean(struct frontend *obj, struct question *q)
 	}
 
 	do {
-		printf("  %d. %s%s", 1, question_get_text(obj, "debconf/yes", "Yes"), (1 == def ? " [*]" : "    "));
-		printf("  %d. %s%s", 2, question_get_text(obj, "debconf/no", "No"), (2 == def ? " [*]" : ""));
+		printf("  %d: %s%s", 1, question_get_text(obj, "debconf/yes", "Yes"), (1 == def ? " [*]" : "    "));
+		printf("  %d: %s%s", 2, question_get_text(obj, "debconf/no", "No"), (2 == def ? " [*]" : ""));
 		printf("\n");
 		if (def)
 			printf(question_get_text(obj, "debconf/text-prompt-default",

--- End Message ---
--- Begin Message --- 
Source: cdebconf
Source-Version: 0.158

We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:

cdebconf-gtk-udeb_0.158_amd64.udeb
  to main/c/cdebconf/cdebconf-gtk-udeb_0.158_amd64.udeb
cdebconf-gtk_0.158_amd64.deb
  to main/c/cdebconf/cdebconf-gtk_0.158_amd64.deb
cdebconf-newt-udeb_0.158_amd64.udeb
  to main/c/cdebconf/cdebconf-newt-udeb_0.158_amd64.udeb
cdebconf-priority_0.158_all.udeb
  to main/c/cdebconf/cdebconf-priority_0.158_all.udeb
cdebconf-text-udeb_0.158_amd64.udeb
  to main/c/cdebconf/cdebconf-text-udeb_0.158_amd64.udeb
cdebconf-udeb_0.158_amd64.udeb
  to main/c/cdebconf/cdebconf-udeb_0.158_amd64.udeb
cdebconf_0.158.dsc
  to main/c/cdebconf/cdebconf_0.158.dsc
cdebconf_0.158.tar.gz
  to main/c/cdebconf/cdebconf_0.158.tar.gz
cdebconf_0.158_amd64.deb
  to main/c/cdebconf/cdebconf_0.158_amd64.deb
libdebconfclient0-dev_0.158_amd64.deb
  to main/c/cdebconf/libdebconfclient0-dev_0.158_amd64.deb
libdebconfclient0-udeb_0.158_amd64.udeb
  to main/c/cdebconf/libdebconfclient0-udeb_0.158_amd64.udeb
libdebconfclient0_0.158_amd64.deb
  to main/c/cdebconf/libdebconfclient0_0.158_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 634076@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Regis Boudin <regis@debian.org> (supplier of updated cdebconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sun, 20 Nov 2011 14:45:06 +0000
Source: cdebconf
Binary: cdebconf cdebconf-gtk libdebconfclient0 libdebconfclient0-dev cdebconf-udeb cdebconf-priority libdebconfclient0-udeb cdebconf-text-udeb cdebconf-slang-udeb cdebconf-newt-udeb cdebconf-gtk-udeb
Architecture: source all amd64
Version: 0.158
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Regis Boudin <regis@debian.org>
Description: 
 cdebconf   - Debian Configuration Management System (C-implementation)
 cdebconf-gtk - Gtk+ frontend for Debian Configuration Management System
 cdebconf-gtk-udeb - Gtk+ frontend for Debian Configuration Management System (udeb)
 cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
 cdebconf-priority - Change debconf priority (udeb)
 cdebconf-slang-udeb - S-Lang frontend for Debian Configuration Management System (udeb)
 cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
 cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
 libdebconfclient0 - Debian Configuration Management System (C-implementation library)
 libdebconfclient0-dev - Development files for cdebconf
 libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 634076
Changes: 
 cdebconf (0.158) unstable; urgency=low
 .
   [ Regis Boudin ]
   * Make more checks at configure time for libs existence.
   * Bring the GTK frontend in line with GTK 2.24 :
     + Compile with GTK_DISABLE_DEPRECATED
     + Compile with GSEAL_ENABLE
     + Use GDK_KEY_* instead of GDK_*
   * Add myself to Uploaders.
   * Factor common code in text frontend, fixing a memory leak.
   * dpkg-reconfigure.c : getfield() reads the status of packages by calling
     dpkg-query instead of manually parsing /var/lib/dpkg/status.
   * Add a symbols file for libdebconfclient0.
   * Stop shipping config and templates directories in /var/lib/cdebconf, which
     are unused.
   * Manage the special case of a metaget owners, returning a comma-separated
     list of the owners. It returned an empty string before.
   * Add cdebconf preinst, postinst, config, and templates files to be able to
     configure frontend and priority.
 .
   [ Samuel Thibault ]
   * Use commas to separate choices for proper speech synthesis.
     Closes: #634076.
Checksums-Sha1: 
 38da6f672dd4bec1870c2a55f5e2c7e6b76b17ab 1956 cdebconf_0.158.dsc
 55eae2a93b425aae13955424a3fbbee9b3cb7d01 354898 cdebconf_0.158.tar.gz
 1e944bbeae0e8f5964b91b61274d437f3b1ad255 3004 cdebconf-priority_0.158_all.udeb
 2c72f4255575f9ac80bb8514a2f00ed06ec9425a 175736 cdebconf_0.158_amd64.deb
 68ed4f121e5f69437b92acc4e70817590536f121 72058 cdebconf-gtk_0.158_amd64.deb
 48e8284ecd8bd221098598532cc3316351d2c506 43260 libdebconfclient0_0.158_amd64.deb
 7fe03a6c5e04c8e5025ae4005b3f6f8c63c82bdc 48872 libdebconfclient0-dev_0.158_amd64.deb
 a460a621de336c854045f2f66260e45ebfb3b43c 87984 cdebconf-udeb_0.158_amd64.udeb
 e6f4c1bb2a879da282ce2305253919d5ac069bd8 3432 libdebconfclient0-udeb_0.158_amd64.udeb
 61615ef78ba9785e71fee6e398c82d11c09c12cd 22408 cdebconf-text-udeb_0.158_amd64.udeb
 8734aa540bad2111e5e20e827fe72db4d9b3e21f 21032 cdebconf-newt-udeb_0.158_amd64.udeb
 5141bb55c2f729ba8c0428450fb1b8adf7127e54 33522 cdebconf-gtk-udeb_0.158_amd64.udeb
Checksums-Sha256: 
 c448461c4c00faa0010d287dea4c642db9a230ae878158a1a1ded16563c96d50 1956 cdebconf_0.158.dsc
 4e6b3a39c1bab27bc1bec771ccd7726f0fa104a053b24fba23ed6f51929d5d3c 354898 cdebconf_0.158.tar.gz
 1f60c844cfd8c2545a220bb9a6cd2c5735f8cb0da3929a5a5ca31a8433bb5eed 3004 cdebconf-priority_0.158_all.udeb
 3ba192d73d2319227e94f601c29e63009ed25fd59250c6554273a2e1ad1a49f1 175736 cdebconf_0.158_amd64.deb
 5c1da71924df544377bf99070c12c8b4d82f3ccbb4ecdcb8c061f4200c11f152 72058 cdebconf-gtk_0.158_amd64.deb
 92ff7aafadc83a148d5bfe13c65b804e0c9b35d732c298d8b2e2e475818c9c85 43260 libdebconfclient0_0.158_amd64.deb
 821238936153c5f7201dcf9ae776330cc1178b89b5fe072b95477c3cd809e2d7 48872 libdebconfclient0-dev_0.158_amd64.deb
 700d35ed28e86875175f8c611b0d6089bac731f88b15b92a984c797b0251ea41 87984 cdebconf-udeb_0.158_amd64.udeb
 1dca4de7c4f700ae38a6a31a5fb99e36ce3a30271241970f580cc5658688caa0 3432 libdebconfclient0-udeb_0.158_amd64.udeb
 d8ab417169f5ea4865838e763b07abb347bd750a2502eee4d964eca58b68cce6 22408 cdebconf-text-udeb_0.158_amd64.udeb
 d3fb7f4c02ea72d99756d7c357883817df4f19c94e385939b3e286b0aa3a3692 21032 cdebconf-newt-udeb_0.158_amd64.udeb
 6b6dc73175c6dc1b22b5983d2575cc9f2501fe6d6f278b2c12621c8b67217325 33522 cdebconf-gtk-udeb_0.158_amd64.udeb
Files: 
 6292d535c192593f2bb18d3e2dd7323f 1956 utils optional cdebconf_0.158.dsc
 6a16ff684050e5eb18481d6ac0d5ea21 354898 utils optional cdebconf_0.158.tar.gz
 b43fcdbb4a509c39a1f0727109743cde 3004 debian-installer standard cdebconf-priority_0.158_all.udeb
 116b6fe95643868daf0d459950709e6f 175736 utils extra cdebconf_0.158_amd64.deb
 b5d599bcec3c329e0d83dcc3564e5563 72058 admin optional cdebconf-gtk_0.158_amd64.deb
 061a0832e1052483406aa14a02363744 43260 libs optional libdebconfclient0_0.158_amd64.deb
 3ed86fa4640dabf6b0d53cc1c6e07b39 48872 libdevel optional libdebconfclient0-dev_0.158_amd64.deb
 72a9ad952e75daeabbd28f3d389aca97 87984 debian-installer standard cdebconf-udeb_0.158_amd64.udeb
 e65affe8d046b68a84b564b9ce748b18 3432 debian-installer optional libdebconfclient0-udeb_0.158_amd64.udeb
 991b58fed2feee2c16c930bd29bdb3d2 22408 debian-installer optional cdebconf-text-udeb_0.158_amd64.udeb
 e0fa514c79e11e64c314f3490b0a2f54 21032 debian-installer optional cdebconf-newt-udeb_0.158_amd64.udeb
 7ae30ddf41183e5b656b0d615a8c92e2 33522 debian-installer optional cdebconf-gtk-udeb_0.158_amd64.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk7JFiEACgkQVE17sLEtWVq32ACdH5gURJaFydOB36jr5UzYcD3/
6EoAn2TUyjIpigQYg/yysmlTg/iU/buY
=MKFD
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: