[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#636040: finish-install: hvc0 console added to inittab even when not available



On 30 Jul 2011, at 14:56, Ian Campbell wrote:

> (please keep 636040@bugs.debian.org CC'd so this conversation is
> recorded on the bug)

Sorry - missed that last time.
> 
> On Sat, 2011-07-30 at 14:43 +0100, Dominic Benson wrote:
>> On 30 Jul 2011, at 14:40, Ian Campbell wrote:
>> 
>>> On Sat, 2011-07-30 at 14:10 +0100, Dominic Benson wrote:
>>>> Package: finish-install
>>>> Version: 2.32
>>>> Severity: normal
>>>> 
>>>> finish-install 90console script checks for the existence of 
>>>> /sys/bus/xen to determine whether to add a console on 
>>>> /dev/hvc0 - but in 2.6.38 / 2.6.39 this always appears to exist.
>>> 
>>> Do you mean that /sys/bus/xen exists even when not running under Xen? Or
>>> when running under Xen but without the necessary driver (perhaps in an
>>> HVM domain)?
>> 
>> The former - that /sys/bus/xen exists even when not running under Xen.
>> 
>> I've seen it under VMware, Parallels, Virtualbox and on a real
>> hardware box (an old Sunfire v20z)
> 
> OK. Some sort of check for hvc0 is probably in order then.
> 
> Sounds like you have at least the beginnings of a patch -- can you post
> it?

I attach a patch that I've used (against 2.22). It does, for me, prevent the problem on systems that I can test.

I tried it under Citrix Xencenter, and the inittab entry for this console is (correctly) added.

> 
> You mentioned a previous block which added another hvc0 (with vt100), is
> that the one inside the "if [ -e $DT_ROOT/chosen/linux,stdout-path ];
> then" block? I think that one is safe.

OK. I'm not really sure under what real circumstances it would be entered. 

My concern was that, if it is used, as /sys/bus/xen and /dev/hvc0 must both exist, two inittab lines would be produced with the same id. 
It strikes me that that would be in some way bad, although I haven't tried it.


Dominic

Attachment: finish-install_hvc0-check.patch
Description: Binary data



Reply to: