[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SRM] Approval for partconf_1.36squeeze1



Dear stable release managers,

I would like to fix a bug in partconf, which prevent installing a MIPS
machine using preseeding, as it's not possible to change the default
values of two debconf questions.

Please consider the diff below for partconf in stable.

Aurelien


diff --git a/debian/changelog b/debian/changelog
index bf599d6..b283bf6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+partconf (1.36squeeze1) stable-proposed-updates; urgency=low
+
+  [ Aurelien Jarno ]
+  * Don't set default debconf values, they are already set in the
+    templates. This fixes preseeding.
+
+ -- Aurelien Jarno <aurel32@debian.org>  Sat, 12 Feb 2011 22:31:09 +0100
+
 partconf (1.36) unstable; urgency=low
 
   [ Updated translations ]
diff --git a/partconf.c b/partconf.c
index b7d290d..c4a3d31 100644
--- a/partconf.c
+++ b/partconf.c
@@ -266,7 +266,6 @@ sanity_checks(void)
         // XXX something like "Partitions 1, 3 and 7 on IDE3 master", but this
         // XXX is probably hard, especially for i18n. :-( If multi-line
         // XXX substitutions worked, we could just list the partitions.
-        debconf_set(debconf, "partconf/confirm", "false");
         debconf_input(debconf, "critical", "partconf/confirm");
         if (debconf_go(debconf) == 30)
             return 0;
@@ -602,7 +601,6 @@ main(void)
 
     if (check_proc_mounts("")) {
         // Chicken out if /target is already mounted
-        debconf_set(debconf,"partconf/already-mounted", "no");
         debconf_input(debconf, "critical", "partconf/already-mounted");
         debconf_go(debconf);
         debconf_get(debconf,"partconf/already-mounted");

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net


Reply to: