Bug#609476: installation-reports: Insufficient care in pre-install script risks bricking Linkstation
A Domingo 09 Janeiro 2011 19:05:54 John Bytheway você escreveu:
> Package: installation-reports
> Severity: critical
> Tags: patch
> Justification: breaks the whole system
>
> I attempted to install Debian squeeze on my Buffalo Linkstation Live
> (LS-CHLv2), as per guidance at
> <http://buffalo.nas-central.org/wiki/Install_Debian_on_the_Linkstation_Pro/
> Live>. Ultimately I failed, but this report concerns one serious issue
> encountered on the way.
>
> The daily snapshots linked from
> <http://www.debian.org/devel/debian-installer/> include this script:
> <http://people.debian.org/~joeyh/d-i/armel/images/daily/orion5x/network-con
> sole/buffalo/lspro/config-debian> intended to prepare the system for reboot
> into the Debian kernel. One of the ways in which this script can fail is
> that the buffalo version is not fetched from the environment. However, in
> this case the script does not exit and proceeds to attempt to modify the
> environment. If the users /etc/fw_env.config is incorrect (as mine was)
> then this attempt to fetch the version will fail, and the subsequent
> modification of the environment might modify an arbitrary portion of the
> system's flash memory, potentially rendering it unbootable. Luckily I
> noticed this issue when fw_printenv failed for other reasons, and
> fw_setenv failed also.
>
> I propose adding an "exit 1" to the script after the error message related
> to this issue. For completeness, I would also recommend exiting from the
> script if the attempt to back up the pre-existing environment fails. The
> attached patch to config-debian includes both changes.
>
> -- System Information:
> Debian Release: 5.0.7
> APT prefers stable
> APT policy: (500, 'stable')
> Architecture: armel (armv5tejl)
>
> Kernel: Linux 2.6.22.18-88f6281
> Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/bash
The script's URL is not found.
--
Melhores cumprimentos/Best regards,
Miguel Figueiredo
http://www.DebianPT.org
Reply to: