[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH 2/3] Make udhcpc continuously retry getting a lease until dhcp_timeout.

Matthew Palmer <mpalmer@debian.org> writes:

> On Thu, Jan 06, 2011 at 09:32:02PM +0100, Ferenc Wagner wrote:
>> Signed-off-by: Ferenc Wagner <wferi@niif.hu>
>> ---
>>  packages/netcfg/dhcp.c |   10 ++++++++--
>>  1 files changed, 8 insertions(+), 2 deletions(-)
>> diff --git a/packages/netcfg/dhcp.c b/packages/netcfg/dhcp.c
>> index f706c5c..385799b 100644
> I've reviewed and tested this patch, and it looks good.  I tested it by
> running a DHCP install with the DHCP server off, and then starting it when
> the progress bar was at around 50%.  Without the patch applied, DHCP failed
> and I was asked to manually configure the network.  With the patch applied,
> udhcpc quickly found the DHCP server and we were away.  Dumping the traffic
> with tcpdump also showed a lot more DHCP requests flying around.

Thanks for the review and the testing!

> I'd recommend this patch be applied before the Squeeze release, as there are
> a number of bugs related to DHCP timeouts, as Ferenc mentions.  I'm not sure
> that the other patches should be applied pre-Squeeze; the cleanups involved
> are minor.

Yes, they don't even influence the object code I suppose.  I included
the first only because the next part touched that line anyway, so it
would feel silly to leave the mistake in place.

> Otavio, any objection to me committing this patch to SVN?  (I'm assuming
> that Ferenc doesn't have SVN commit access...)

Correct. :)

Reply to: