[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#568495: marked as done ([patch] partman-auto-raid/README)

Your message dated Sun, 7 Feb 2010 13:38:44 +0100
with message-id <201002071338.45456.elendil@planet.nl>
and subject line Re: Bug#568495: [patch] partman-auto-raid/README
has caused the Debian Bug report #568495,
regarding [patch] partman-auto-raid/README
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
568495: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=568495
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: partman-auto-raid
Version: 15
Severity: wishlist
Tags: patch

Hi,

I found what I think is a minor error in the partman-auto-raid/README
(the elements of the recipes should be separated by periods, not commas).

The attached corrects that and tries to clarify two parts of the text
I found confusing or too terse.

Please consider applying this patch.

Cheers
Vince

Index: trunk/packages/partman/partman-auto-raid/README
===================================================================
--- trunk/packages/partman/partman-auto-raid/README	(revision 62177)
+++ trunk/packages/partman/partman-auto-raid/README	(working copy)
@@ -2,8 +2,8 @@
 partman-auto/method to "raid" and using partman-auto-raid/recipe to tell
 it how to construct the RAID array(s).
 
-The preseedable parameter partman-auto-raid/recipe should consist of comma
-separated recipes and recipes are of the form:
+The preseedable parameter partman-auto-raid/recipe should consist of
+recipes separated by periods (.). The recipes are of the form:
 
 <raidtype> <devcount> <sparecount> <fstype> <mountpoint> <devices> <sparedevices>
 
@@ -12,9 +12,11 @@
 array.
 
 e.g.
-1 2 0 ext3 / /dev/sda1#/dev/sdb1 .
-1 2 0 swap / /dev/sda5#/dev/sdb5 .
-(but without the line break)
+d-i partman-auto-raid recipe string  \
+  1 2 0 ext3 / /dev/sda1#/dev/sdb1 . \
+  1 2 0 swap - /dev/sda5#/dev/sdb5 .
+This must be written all on one line; if you write it across multiple lines
+you must use continuation characters.
 
 This makes the first RAID device that was created by this udeb be a RAID1 of
 two disks disc0/part1 and disc1/part1 and be formatted as ext3 and mounted
@@ -46,8 +48,17 @@
 		/dev/sda5#/dev/sdb5			\
 	.
 
-# Please note that RAID partitions are tagged as "lvmignore"
-# and LVM logical volumes as "defaultignore" and "lvmok".
+# In the expert_recipe, there is a stanza for each RAID partition
+# and each LVM partition.
+# The RAID partitions are tagged as "lvmignore", while
+# the LVM logical volumes as "defaultignore" and "lvmok".
+# The RAID partition containing the LVM volumes must be made big
+# enough to hold them all.
+# Note that in the example shown here the mountpoint for /boot
+# (which is not encapsulated within LVM) is specified in the
+# partman-auto-raid recipe, rather than in the corresponding 
+# raid partition definition below.
+#
 d-i partman-auto/expert_recipe string			\
 	multiraid ::					\
 		100 512 256 raid			\

--- End Message ---
--- Begin Message --- 
On Sunday 07 February 2010, Frans Pop wrote:
> On Friday 05 February 2010, Vincent McIntyre wrote:
> > I found what I think is a minor error in the partman-auto-raid/README
> > (the elements of the recipes should be separated by periods, not
> > commas).
>
> Hmmm. I wonder if you read that correctly. It's true that the elements
> *within* a recipe must be separated by periods. But if you set multiple
> recipes, then those should be separated by commas.

No, looking at it again I think you were correct. I've applied the patch 
(with a few added changes of my own).

Thanks again.

--- End Message ---
Reply to: