[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#563825: os-prober: /u/l/os-probes/mounted/20microsoft spits an error if partition name contains a blank character



Package: os-prober
Version: 1.35
Severity: normal

Hi,

i have an external HDD connected to my USB port. the manufacturer has chosen the name "MY PASSPORT" for its primary partition. When I run os-prober, it spits the following error message
  ls: cannot access /media/MY: No such file or directory

This happens, because in line 57 in /usr/lib/os-probes/mounted/20microsoft the mount point is passed to item_in_dir() without quoting, resulting in "/media/MY" to be interpreted as the second argument and "PASSPORT" as the third.

The attached patch fixes this behaviour.

Cheers,
Fabian


-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (550, 'unstable'), (400, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.32-trunk-686 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages os-prober depends on:
ii  libc6                         2.10.2-3   Embedded GNU C Library: Shared lib

os-prober recommends no packages.

os-prober suggests no packages.

-- no debconf information
--- 20microsoft	2010-01-05 16:57:01.000000000 +0100
+++ /usr/lib/os-probes/mounted/20microsoft	2010-01-05 16:58:02.000000000 +0100
@@ -54,7 +54,7 @@
 		fi
 	fi
 # MS-DOS
-elif [ -d "$(item_in_dir dos $2)" ]; then
+elif [ -d "$(item_in_dir dos "$2")" ]; then
 	long="MS-DOS 5.x/6.x/Win3.1"
 	short=MS-DOS
 # 95/98/Me

Reply to: