[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#606621: marked as done (mklibs-readelf: segfaults on static objects)



Your message dated Fri, 24 Dec 2010 21:32:29 +0000
with message-id <E1PWFFV-00074c-I0@franck.debian.org>
and subject line Bug#606621: fixed in mklibs 0.1.31
has caused the Debian Bug report #606621,
regarding mklibs-readelf: segfaults on static objects
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
606621: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=606621
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: mklibs
Version: 0.1.30
Severity: important
Tags: patch

This was originally found on armhf (a new port on debian-ports.org), when
doing d-i work,  but was also reproduced on amd64 and Ubuntu armel -which
I guess uses the same source.

You can easily check it by doing:

$ mklibs-readelf -n /sbin/ldconfig.real
Segmentation fault

I attach a simple patch that fixes this. It just checks to see if the
about-to-be-checked elf dynamic section is non-null. This should be
trivial to include, so please do so, I had d-i build image fail on me
because of this.

Thanks.

Konstantinos

-- System Information:
Debian Release: squeeze/sid
Architecture: armhf (armv7l)

Kernel: Linux 2.6.31.14-efikamx (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -ruN mklibs-0.1.30/src/mklibs-readelf/main.cpp mklibs-0.1.30.fixed//src/mklibs-readelf/main.cpp
--- mklibs-0.1.30/src/mklibs-readelf/main.cpp	2010-06-02 17:47:32.000000000 +0000
+++ mklibs-0.1.30.fixed//src/mklibs-readelf/main.cpp	2010-12-10 12:32:08.939766620 +0000
@@ -56,11 +56,14 @@
 static void process_dynamics (Elf::file *file, int64_t tag)
 {
   const Elf::section_type<Elf::section_type_DYNAMIC> *section = file->get_section_DYNAMIC ();
-  for (std::vector<Elf::dynamic *>::const_iterator it = section->get_dynamics ().begin (); it != section->get_dynamics ().end (); ++it)
-  {
-    Elf::dynamic *dynamic = *it;
-    if (dynamic->get_tag () == tag)
-      std::cout << dynamic->get_val_string () << '\n';
+  std::cout << "process_dynamics: section = " << std::hex << section << "\n";
+  if (section != NULL) {
+    for (std::vector<Elf::dynamic *>::const_iterator it = section->get_dynamics ().begin (); it != section->get_dynamics ().end (); ++it)
+    {
+      Elf::dynamic *dynamic = *it;
+      if (dynamic->get_tag () == tag)
+        std::cout << dynamic->get_val_string () << '\n';
+    }
   }
 }
 

--- End Message ---
--- Begin Message ---
Source: mklibs
Source-Version: 0.1.31

We believe that the bug you reported is fixed in the latest version of
mklibs, which is due to be installed in the Debian FTP archive:

mklibs-copy_0.1.31_amd64.deb
  to main/m/mklibs/mklibs-copy_0.1.31_amd64.deb
mklibs_0.1.31.dsc
  to main/m/mklibs/mklibs_0.1.31.dsc
mklibs_0.1.31.tar.gz
  to main/m/mklibs/mklibs_0.1.31.tar.gz
mklibs_0.1.31_all.deb
  to main/m/mklibs/mklibs_0.1.31_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 606621@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Otavio Salvador <otavio@debian.org> (supplier of updated mklibs package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 24 Dec 2010 19:20:29 -0200
Source: mklibs
Binary: mklibs mklibs-copy
Architecture: source all amd64
Version: 0.1.31
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Otavio Salvador <otavio@debian.org>
Description: 
 mklibs     - Shared library reduction script
 mklibs-copy - Shared library reduction script
Closes: 585254 606621
Changes: 
 mklibs (0.1.31) unstable; urgency=low
 .
   [ Colin Watson ]
   * Use 'dh $@ --options' rather than 'dh --options $@', for
     forward-compatibility with debhelper v8.
 .
   [ Bastian Blank ]
   * Support python 2.6 (closes: #585254)
   * Don't fail with static binaries (closes: #606621)
Checksums-Sha1: 
 eceb8d9be8af26dd1e103beff22d3eb036e2c8d0 1631 mklibs_0.1.31.dsc
 7572d31a59d3f44ebb91d72eac1bf9adc07e102f 134262 mklibs_0.1.31.tar.gz
 0cffd9ebf51d0310b2370e1af9ad16bf4bbcfaaf 13486 mklibs_0.1.31_all.deb
 e949d709744fcefd2e833a2b646e16af7447e223 48522 mklibs-copy_0.1.31_amd64.deb
Checksums-Sha256: 
 33ce62d6e2c85fe411dd53237e74dd9a331f417bed3922850519ac4d55b8090e 1631 mklibs_0.1.31.dsc
 8f5595621eb09d52871c771861e81b032d10c31d15e5dd61fa7f5a9e5b7de405 134262 mklibs_0.1.31.tar.gz
 ec8d21441bf80b51191629ec32ff3aa7e5662ede53d7a22d20a398cbdd918a56 13486 mklibs_0.1.31_all.deb
 a7810a34096c88cb4f4e8122a02bc961056296690529358cbba411ec9851ceae 48522 mklibs-copy_0.1.31_amd64.deb
Files: 
 4d95eca1e144fefb1e91ffa56e9db74f 1631 devel optional mklibs_0.1.31.dsc
 f4df0307ccbdf60070e42277513f27ed 134262 devel optional mklibs_0.1.31.tar.gz
 034a5b6343fdb9b2a110812919f59aba 13486 devel optional mklibs_0.1.31_all.deb
 b47c6b8c6aa07f9f9fe851cf0c051eaf 48522 devel optional mklibs-copy_0.1.31_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBCAAGBQJNFQ6sAAoJEOtw/vPN/G5PQtwP/AuhiKpIXzEGKEVru20mj5ih
0elGPcNWfkHlsmKKY60qw5vEs2bfQRRjBAgXq56ubKBv7Nvnp+tlKELThJJDBa0a
NAQthXg3H4XCEzrUj9pljbWYWp9BdpJRuxzG69MSQs9hONL9Fzl+ZECIZrEub87K
iP8kO8dCFYOXKfSb4g6Xi823JfZ9Ddq01soWcMrU/MgKeHB3K4XMBtwhKmiItO3f
n99so6ks+IJoqabTiRXd+WDVzuTJHT5mj7RuWs7//S6wOzNHykueu2ANOogshBx8
HnhQfJi9qK+8LtOcehJjL/aKqXqXS4ggj/lifskKZaghidAGT2TexctyDbnloK6m
oBGsUZLXV/4isbMpGeydpVxNnZWLAD0q/idwRXumwlazjKRt0kMy3+USIH7kA64i
TBtM3Yij/Zdc5JqMem3qh5/sB8MQk2qjlju/GfIc93W26VHLY5MQOxVnjzFfTHuD
2TJe64f5xcvq1jrrVJAxqTnvH76baM8pbj+233kyTPBOLy4pMErlwvk1XG8utcXT
PuOYSkiAC3NDAEZBRw2kp86HNrMfZ78NFr8rnkHlZ+uO0EXYu3jaOtpED/cSDxei
Yk28z42jmNpwOalpLcVT2Y1wDR+m4PxKTsVfWZ01yNHyiiqizf5HkxtYVEpMpidN
+ACo+8TUWun09WzLxok2
=OzS4
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: