[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#605938: discover-pkginstall cancels d-i pkgsel progress bar

Package: discover
Version: 2.1.2-4
Severity: normal
Tag: patch
Tag: d-i

Since discover-pkginstall uses debconf-apt-progress, it starts
up, and then takes down a progress bar. This messes up the
main pkgsel progress bar used in d-i, in cases where
discover detects it should install something. (This is known
to happen in eg, virtualbox-ose.)

The attached untested patch adds an environment variable that can be
used to avoid it messing with the progress bar. I have made hw-detect
(1.83) set the variable when running discover-pkginstall.

see shy jo
diff -ur old/discover-2.1.2/scripts/discover-pkginstall discover-2.1.2/scripts/discover-pkginstall
--- old/discover-2.1.2/scripts/discover-pkginstall	2010-12-04 16:03:36.000000000 -0400
+++ discover-2.1.2/scripts/discover-pkginstall	2010-12-04 16:08:34.050134457 -0400
@@ -171,7 +171,12 @@
         if [ "$packages" ] ; then
             if [ -x /usr/bin/debconf-apt-progress ] ; then
-                $nop debconf-apt-progress -- aptitude install -q -y $packages
+		if [ "$DI_PROGRESS_BAR_VISIBLE" ]; then
+		    debconf_apt_progress_opts=--no-progress
+		else
+		    debconf_apt_progress_opts=
+		fi
+                $nop debconf-apt-progress $debconf_apt_progress_opts -- aptitude install -q -y $packages
                 $nop aptitude install -y $packages

Attachment: signature.asc
Description: Digital signature

Reply to: