On Sun, 31 Oct 2010 11:02:33 -0400
Joey Hess <joeyh@debian.org> wrote:
> Karl Goetz wrote:
> > Attached patch changes scripts/{sid,gutsy} to use tabs instead of
> > mixed spaces and tabs.
> > This allows diff to create a useful comparison of the files (and
> > has revealed a couple of seemingly pointless differences).
>
> Some I've resolved now. Leaving notably:
[trim some stuff]
> Seems like the gutsy script is either more or less robust here without
> the || echo , not sure which. :)
>
> The 7>&1 is the largest source of divergence. I don't see why the
> gutsy script couldn't use the same one-time redirect that sid does.
> However, I don't fully understand the FD dance going on here.
I wasn't game to try patching them, hopefully someone knows how it
works.
> @@ -153,12 +160,21 @@
> echo \"Warning: Fake start-stop-daemon called, doing nothing\"" >
> "$TARGET/sbin/start-stop-daemon" chmod 755
> "$TARGET/sbin/start-stop-daemon"
> + if [ -x "$TARGET/sbin/initctl" ]; then
> + mv "$TARGET/sbin/initctl" "$TARGET/sbin/initctl.REAL"
> + echo \
> +"#!/bin/sh
> +echo
> +echo \"Warning: Fake initctl called, doing nothing\"" >
> "$TARGET/sbin/initctl"
> + chmod 755 "$TARGET/sbin/initctl"
> + fi
>
> If debian ever gets upstart in base, we could use that too, I guess
> not needed yet. (Though it couldn't hurt to put it in..)
>
ah, wondered what it was for.
thanks for those changes.
kk
--
Karl Goetz, (Kamping_Kaiser / VK5FOSS)
Debian contributor / gNewSense Maintainer
http://www.kgoetz.id.au
No, I won't join your social networking group
Attachment:
signature.asc
Description: PGP signature