Le mardi 31 août 2010 à 22:29 +0100, Martin Michlmayr a écrit : > * Thibaut GIRKA <thib@sitedethib.com> [2010-08-16 16:15]: > > -XB-Subarchitecture: iop32x ixp4xx kirkwood orion5x > > +XB-Subarchitecture: iop32x ixp4xx kirkwood orion5x s3c24xx > > Is s3c24xx what was decided in the end? I remember there was a lot of > discussion of s3c vs s3c24xx but I cannot remember the outcome. If you're talking about the discussion in #503292, then yes, s3c24xx was decided. > > + "GTA02") > > + return 1 > > Is this really what this device will be called in the mainline kernel? > IMHO it would make more sense to use a more descriptive name, but if > GTA02 has been decided already that's obviously fine. There is already basic (really basic, no display or even µSD) support in mainline kernel, and the name is "GTA02". > > + # Modify u-boot environment > > + rootfs=$(findfs /) > > + bootfs=$(findfs /boot) > > + modify_uboot_env $rootfs $bootfs > > + ;; > > I suggest you move this patch out to the patch in #586221. This way, > the current patch can be applied even without the fix for #586221. Ok, I'll probably do that. > > + check_subarch "s3c24xx" > > + tmp="$(tempfile)" > > + printf "Generating u-boot image..." >&2 > > + gzip -9 -c "$kfile" > "$tmp" > > Why do you need to compress the kernel? It should be a zImage or > LZMA-image already anywhere. Yeah, I know, that's a bit tricky (I commented it on the d-i target, but I haven't sent it yet). So, U-Boot have an image format called multi-file images. But there is only one header for the whole image, and so, only one compression method. This compression method is used both to uncompress the kernel and as the compression type of the initrd image. If I don't compress the kernel and say "-C gzip", U-Boot will try to uncompress the kernel, and will obviously fail (since the kernel is executable and uncompress itself). If I specify "-C none", it'll run the kernel just fine, but will fail to tell the kernel that the initrd image is gzip-compressed... So, the only way is to re-compress the kernel... > > + mkimage -A arm -O linux -T multi -C gzip -a 0x30008000 \ > > + -e 0x30008000 -n "$desc" -d "$tmp":"$ifile" "$tmp.uboot" >&2 1>/dev/null > > + echo "done." >&2 > > Will this actually boot on any Freerunner machines without the -p > option you proposed in #584166? If you're lucky. Indeed, the chances aren't negligible, maybe this bug will wait for #584166.
Attachment:
signature.asc
Description: This is a digitally signed message part