[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#588776: marked as done (base-installer: please don't rely on /proc/mounts, which is not available on Hurd)

Your message dated Mon, 23 Aug 2010 09:47:07 +0000
with message-id <E1OnTcR-0002Ul-Nj@franck.debian.org>
and subject line Bug#588776: fixed in base-installer 1.109
has caused the Debian Bug report #588776,
regarding base-installer: please don't rely on /proc/mounts, which is not available on Hurd
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
588776: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588776
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: base-installer
Version: 1.108
Tags: patch
Usertags: gsoc2010

Hello,

bootstrap-base starts by checking that something is mounted on /target,
using /proc/mounts. On Hurd, /proc/mounts does not exist, and
bootstrap-base fails as a result.

The attached patch short-circuits the /target check when /proc/mounts
does not exist.

-- 
Jeremie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org

Index: base-installer/debian/changelog
===================================================================
--- base-installer/debian/changelog	(revision 63843)
+++ base-installer/debian/changelog	(working copy)
@@ -1,3 +1,9 @@
+base-installer (1.109) UNRELEASED; urgency=low
+
+  * Don't check /proc/mounts if it does not exist (ie. on Hurd).
+
+ -- Jeremie Koenig <jk@jk.fr.eu.org>  Sun, 11 Jul 2010 22:36:14 +0000
+
 base-installer (1.108) unstable; urgency=low
 
   [ Martin Michlmayr ]
Index: base-installer/library.sh
===================================================================
--- base-installer/library.sh	(revision 63843)
+++ base-installer/library.sh	(working copy)
@@ -86,7 +86,8 @@
 check_target () {
 	# Make sure something is mounted on the target.
 	# Partconf causes the latter format.
-	if ! grep -q '/target ' /proc/mounts && \
+	if [ -e /proc/mounts ] && \
+	   ! grep -q '/target ' /proc/mounts && \
 	   ! grep -q '/target/ ' /proc/mounts; then
 		exit_error base-installer/no_target_mounted
 	fi

--- End Message ---
--- Begin Message --- 
Source: base-installer
Source-Version: 1.109

We believe that the bug you reported is fixed in the latest version of
base-installer, which is due to be installed in the Debian FTP archive:

base-installer_1.109.dsc
  to main/b/base-installer/base-installer_1.109.dsc
base-installer_1.109.tar.gz
  to main/b/base-installer/base-installer_1.109.tar.gz
base-installer_1.109_all.udeb
  to main/b/base-installer/base-installer_1.109_all.udeb
bootstrap-base_1.109_amd64.udeb
  to main/b/base-installer/bootstrap-base_1.109_amd64.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 588776@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurelien Jarno <aurel32@debian.org> (supplier of updated base-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 23 Aug 2010 11:23:24 +0200
Source: base-installer
Binary: base-installer bootstrap-base
Architecture: source all amd64
Version: 1.109
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Aurelien Jarno <aurel32@debian.org>
Description: 
 base-installer - base system installation framework (udeb)
 bootstrap-base - Install the base system (udeb)
Closes: 588776
Changes: 
 base-installer (1.109) unstable; urgency=low
 .
   [ Jeremie Koenig ]
   * Don't check /proc/mounts if it does not exist (ie. on Hurd) (Closes:
     Bug#588776).
 .
   [ Aurelien Jarno ]
   * Teach library.sh how to do a bind mount on Hurd and GNU/kFreeBSD.
 .
   [ Updated translations ]
   * Asturian (ast.po) by maacub
   * Bulgarian (bg.po) by Damyan Ivanov
   * Bosnian (bs.po) by Armin Beširović
   * Danish (da.po) by Jacob Sparre Andersen
   * Persian (fa.po) by Ebrahim Byagowi
   * Finnish (fi.po) by Esko Arajärvi
   * Kazakh (kk.po) by Baurzhan Muftakhidinov
   * Panjabi (pa.po) by A S Alam
   * Portuguese (Brazil) (pt_BR.po) by Felipe Augusto van de Wiel (faw)
   * Serbian (sr.po) by Karolina Kalic
   * Telugu (te.po) by Arjuna Rao Chavala
Checksums-Sha1: 
 2f78fa7bbf6031299a0786d401af4df9d85a9256 1058 base-installer_1.109.dsc
 55f543c5ef8d487275cef86e38a8ddba61c791bb 278205 base-installer_1.109.tar.gz
 1849ea6981688930efca71f1f86f355d90cb9271 42548 base-installer_1.109_all.udeb
 7461fa6c031ef1b6326f439ca86919319fa8faff 169432 bootstrap-base_1.109_amd64.udeb
Checksums-Sha256: 
 d181e31ce2ab67e9b1ad63d83d3d0fb1faf485490751a437016b11a4e03c1073 1058 base-installer_1.109.dsc
 7f602d780dd46b826f67e9e05431f17777cf65b786ffe63aa0edaa7c17e82cc0 278205 base-installer_1.109.tar.gz
 dad66f75c3a16af5eafa3a5666799d160ae641011897a56e2bae1e27417ce3ca 42548 base-installer_1.109_all.udeb
 4561a7c39d33e41cec9a45590a721a4bcf50ed183f8e922925523af8e0c2529d 169432 bootstrap-base_1.109_amd64.udeb
Files: 
 1712f65b93bbaf949a90f076a3c81619 1058 debian-installer required base-installer_1.109.dsc
 e8c2845daf85a427d987deea58e976da 278205 debian-installer required base-installer_1.109.tar.gz
 7ac25129b64804a2ae406178d13e6c12 42548 debian-installer required base-installer_1.109_all.udeb
 e06be857411f6e06330d138f14f1f74e 169432 debian-installer required bootstrap-base_1.109_amd64.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMcj82w3ao2vG823MRAlliAJ4hA6SBzHggjW7b3Se/WqmPxXXOFACeMs3J
8tdlx2qgYQujCDfN5SIeZOk=
=lkDG
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: