[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#592671: marked as done (partman-target: /target/etc/fstab is not created on Hurd)



Your message dated Sun, 22 Aug 2010 22:32:21 +0000
with message-id <E1OnJ5R-0000fN-Jz@franck.debian.org>
and subject line Bug#592671: fixed in partman-target 69
has caused the Debian Bug report #592671,
regarding partman-target: /target/etc/fstab is not created on Hurd
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
592671: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592671
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: partman-target
Version: 68
Tags: patch
Usertags: gsoc2010

Hello,

The following pieces are missing to have /target/etc/fstab created on Hurd:
  - finish.d/create_fstab_header has no 'hurd' case;
  - the default "mount style" must be 'traditional' on Hurd, since there
    is no volume id support at the moment.

The attached patch adds them. The default value for partman/mount_style
is changed by debian/rules at build time, using an approach similar to
what partman-base does for partman/default_filesystem.

NB: if you commit this patch, remember to substitute the bug number in
debian/changelog.

Thanks,
-- 
Jeremie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org
Index: partman-target/debian/changelog
===================================================================
--- partman-target/debian/changelog	(revision 64302)
+++ partman-target/debian/changelog	(working copy)
@@ -1,10 +1,17 @@
 partman-target (69) UNRELEASED; urgency=low
 
+  [ Colin Watson ]
   * Use 'dh $@ --options' rather than 'dh --options $@', for
     forward-compatibility with debhelper v8.
 
- -- Colin Watson <cjwatson@debian.org>  Tue, 13 Jul 2010 10:53:29 +0100
+  [ Jeremie Koenig ]
+  * Hurd support (closes: #<please fill-in>):
+    - finish.d/create_fstab_header: add a hurd case;
+    - debian/rules: set as OS-dependant default for partman/mount_style,
+      using the same method as partman-base for partman/default_filesystem.
 
+ -- Jeremie Koenig <jk@jk.fr.eu.org>  Wed, 11 Aug 2010 20:02:47 +0000
+
 partman-target (68) unstable; urgency=low
 
   [ Updated translations ]
Index: partman-target/debian/rules
===================================================================
--- partman-target/debian/rules	(revision 64302)
+++ partman-target/debian/rules	(working copy)
@@ -1,3 +1,20 @@
 #! /usr/bin/make -f
 %:
 	dh $@ --with d-i
+
+ARCH_OS=$(shell dpkg-architecture -qDEB_HOST_ARCH_OS)
+
+ifeq ($(ARCH_OS),linux)
+DEFAULT_STYLE=uuid
+endif
+ifeq ($(ARCH_OS),kfreebsd)
+DEFAULT_STYLE=uuid
+endif
+ifeq ($(ARCH_OS),hurd)
+DEFAULT_STYLE=traditional
+endif
+
+override_dh_installdebconf:
+	dh_installdebconf
+	sed -i '/^Template: partman\/mount_style/,/^$$/s/^Default: .*/Default: $(DEFAULT_STYLE)/' \
+		debian/partman-target/DEBIAN/templates
Index: partman-target/finish.d/create_fstab_header
===================================================================
--- partman-target/finish.d/create_fstab_header	(revision 64302)
+++ partman-target/finish.d/create_fstab_header	(working copy)
@@ -28,5 +28,13 @@
 		printf "%-15s %-15s %-7s %-15s %-7s %s\n" sys /sys linsysfs rw 0 0 >> /target/etc/fstab
 		printf "%-15s %-15s %-7s %-15s %-7s %s\n" fdesc /dev/fd fdescfs rw 0 0 >> /target/etc/fstab
 	;;
+
+	hurd)
+		cat >/target/etc/fstab <<EOF
+# /etc/fstab: static file system information.
+#
+EOF
+		printf "%-15s %-15s %-7s %-15s %-7s %s\n" '# <file system>' '<mount point>' '<type>' '<options>' '<dump>' '<pass>' >> /target/etc/fstab
+	;;
 esac
 

--- End Message ---
--- Begin Message ---
Source: partman-target
Source-Version: 69

We believe that the bug you reported is fixed in the latest version of
partman-target, which is due to be installed in the Debian FTP archive:

partman-target_69.dsc
  to main/p/partman-target/partman-target_69.dsc
partman-target_69.tar.gz
  to main/p/partman-target/partman-target_69.tar.gz
partman-target_69_all.udeb
  to main/p/partman-target/partman-target_69_all.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 592671@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurelien Jarno <aurel32@debian.org> (supplier of updated partman-target package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 23 Aug 2010 00:23:20 +0200
Source: partman-target
Binary: partman-target
Architecture: source all
Version: 69
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Aurelien Jarno <aurel32@debian.org>
Description: 
 partman-target - Provides partman with ability to prepare /target (udeb)
Closes: 592671
Changes: 
 partman-target (69) unstable; urgency=low
 .
   [ Colin Watson ]
   * Use 'dh $@ --options' rather than 'dh --options $@', for
     forward-compatibility with debhelper v8.
 .
   [ Jeremie Koenig ]
   * Hurd support (closes: #592671):
     - finish.d/create_fstab_header: add a hurd case;
     - debian/rules: set as OS-dependant default for partman/mount_style,
       using the same method as partman-base for partman/default_filesystem.
 .
   [ Aurelien Jarno ]
   * Teach finish.d/fstab_removable_media_entries how to write CD-ROM
     entries in /etc/fstab with the correct filesystem.
Checksums-Sha1: 
 4869e9d80398150ee18e7ef543b84813cfe5ae1b 894 partman-target_69.dsc
 3e1dcb17051464911493367d93b10335bf57946a 129527 partman-target_69.tar.gz
 e3ec65c9f14f405f0c4c0151f408fc5c1324e38c 101826 partman-target_69_all.udeb
Checksums-Sha256: 
 f27709d8d035e4c1db77549f977086f79f2f4d31590a304b8c308ca62cc7f868 894 partman-target_69.dsc
 689c43704ade5cdf85fd07ea17d77d055ee82612c920bb42b6ca89a38903f19c 129527 partman-target_69.tar.gz
 596b47da336d2016c6ac03e232ed6b8a890c052daf9b466761cd463545a17f0e 101826 partman-target_69_all.udeb
Files: 
 11feb07042f03f2dd0a8433b1163243e 894 debian-installer standard partman-target_69.dsc
 aad0f64296fe023e18e9ca0919acfe04 129527 debian-installer standard partman-target_69.tar.gz
 9a6e7b32a87e6fc136ae2b3daa5ccc89 101826 debian-installer standard partman-target_69_all.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMcaOLw3ao2vG823MRAgNjAJ9EBPLz5aD1XJ4Fuqm/UxWerpCLlQCfYXod
+PHc4UoKZW99tZwuzMEq+Js=
=Xt1q
-----END PGP SIGNATURE-----



--- End Message ---

Reply to: