[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#583388: Non-US keyboard problem with graphical installer

On Tuesday 06 July 2010, Cyril Brulebois wrote:
> 5. Fix for real:
>    Edit /var/lib/dpkg/info/keyboard-configuration.config, and add the
>    following line in ask_debconf(), right before the if part, once all
>    choices have been merged together:
>       choices=`echo $choices | sed 's/,$//'`

Nice job tracing this. It's an error that crops up once in a while (in most 
cases because a comma _inside_ one (translated) option in the option list 
is not escaped and causes a count difference).

The proposed fix could well be OK, but maybe the code can be fixed a bit 
earlier so the trailing comma is avoided in the first place? It's in 
general better to create the option list correctly than to clean it up 
'ask_debconf()' sounds like a rather general function that should be fed 
correct input rather than have this overhead.


Reply to: