Bug#586870: partman-base: use a system-specific default filesystem
Package: partman-base
Version: 141
Severity: normal
Usertags: gsoc2010
Tags: patch
Hello,
Currently the default filesystem is ext3 on all systems. However, Hurd
only supports ext2 and kFreeBSD requires ufs as its root filesystem.
The attached patch sets a system-specific default, provided none has
been preseeded.
An alternative approach would be to load a system-specific "pre-preseed"
file at the beginning of the installation, though I'm not sure what
other configuration items would need system-specific defaults.
My suggestion would be to use my patch as a first step and review the
situation when/if more system-specific defaults prove to be necessary.
Any thoughts? (or irrepressible urges to commit my patch? :-)
Thanks,
--
Jeremie Koenig <jk@jk.fr.eu.org>
http://jk.fr.eu.org
Index: partman-base/debian/changelog
===================================================================
--- partman-base/debian/changelog (revision 63538)
+++ partman-base/debian/changelog (working copy)
@@ -1,9 +1,14 @@
partman-base (142) UNRELEASED; urgency=low
+ [ Colin Watson ]
* Add ALIGNMENT_OFFSET to partman-command.
- -- Colin Watson <cjwatson@debian.org> Sat, 08 May 2010 15:20:19 +0200
+ [ Jeremie Koenig ]
+ * Set a system-specific value for partman/default_filesystem if none has been
+ preseeded.
+ -- Jeremie Koenig <jk@jk.fr.eu.org> Wed, 16 Jun 2010 18:08:50 +0200
+
partman-base (141) unstable; urgency=low
* parted 2.1 changed the semantics of ped_disk_clobber: it now zeroes out
Index: partman-base/init.d/default_filesystem
===================================================================
--- partman-base/init.d/default_filesystem (revision 0)
+++ partman-base/init.d/default_filesystem (revision 0)
@@ -0,0 +1,20 @@
+#!/bin/sh
+
+. /usr/share/debconf/confmodule
+
+db_fget partman/default_filesystem seen
+if [ "$RET" != "false" ]; then
+ exit 0
+fi
+
+case "$(udpkg --print-os)" in
+ "kfreebsd")
+ db_set partman/default_filesystem ufs
+ ;;
+ "hurd")
+ db_set partman/default_filesystem ext2
+ ;;
+esac
+
+db_fset partman/default_filesystem seen true
+
Property changes on: partman-base/init.d/default_filesystem
___________________________________________________________________
Added: svn:executable
+ *
Index: partman-base/init.d/_numbers
===================================================================
--- partman-base/init.d/_numbers (revision 63538)
+++ partman-base/init.d/_numbers (working copy)
@@ -1,5 +1,6 @@
01 early_command
10 umount_target
+20 default_filesystem
30 parted
35 dump
70 update_partitions
Reply to: