Bug#583650: hw-detect: Too high priority for driver-injection-disk/load template?
- To: 583650@bugs.debian.org
- Subject: Bug#583650: hw-detect: Too high priority for driver-injection-disk/load template?
- From: Petter Reinholdtsen <pere@hungry.com>
- Date: Sat, 29 May 2010 22:24:16 +0200
- Message-id: <[🔎] 2fl7hmmsbgv.fsf@login1.uio.no>
- Reply-to: Petter Reinholdtsen <pere@hungry.com>, 583650@bugs.debian.org
- In-reply-to: <20100529074015.27392.23755.reportbug__42943.3460966267$1275118948$gmane$org@mykerinos.kheops.frmug.org> (Christian Perrier's message of "Sat\, 29 May 2010 09\:40\:15 +0200")
- References: <20100529074015.27392.23755.reportbug__42943.3460966267$1275118948$gmane$org@mykerinos.kheops.frmug.org>
tags 583650 + patch
thanks
[Christian Perrier]
> IMHO, this template has a quite sane default and I don't think there
> is a need to display it for default installs. After all, all it is
> asking is "should I try to detect the OEM divers injection disk?"
> which is a quite safe action.
>
> Even though my understanding is that the package itself is used only
> in specific cases, I'd suggest lowering the priority to medium.
I agree as long as the default is true. This patch would do it.
Index: debian/driver-injection-disk-detect.templates
===================================================================
--- debian/driver-injection-disk-detect.templates (revision 63340)
+++ debian/driver-injection-disk-detect.templates (working copy)
@@ -6,6 +6,7 @@
Template: driver-injection-disk/load
Type: boolean
+Default: true
# :sl3:
_Description: Load drivers from internal "drivers disk"?
Installing on this hardware may require some drivers provided by the
Index: driver-injection-disk.sh
===================================================================
--- driver-injection-disk.sh (revision 63340)
+++ driver-injection-disk.sh (working copy)
@@ -32,7 +32,7 @@
for device in $(list-devices usb-partition); do
label=$(block-attr --label $device 2>/dev/null || true)
if [ "$label" = "OEMDRV" ]; then
- db_input high driver-injection-disk/load || true
+ db_input medium driver-injection-disk/load || true
if ! db_go; then
exit 10 # back up
fi
Happy hacking,
--
Petter Reinholdtsen
Reply to: