[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#572013: Patch for #572013, #572008 (bashism in udhcpc/default.script)


Bastian Blank wrote:
> On Mon, Mar 01, 2010 at 02:10:54AM +0100, Axel Beckert wrote:
> > -               /sbin/route add default gw $i dev $interface metric $((metric++))
> > +               /sbin/route add default gw $i dev $interface metric $((metric=metric+1))
> I currently think about why this metric argument is there anyway. The
> script from the isc dhcp does not set it in this case. Maybe it could
> just be removed.

As just discussed on #debian-boot with Otavio, the busybox udeb's
udhcpc (special default.script for the udeb by Otavio) does not set
the metric either, so we should be able to safely drop it, yes.

Axel Beckert wrote:
> Will check for further occurrences of this bashism inside the
> busybox package and add a patch against current SVN to this bug
> report.

In the meanwhile I indeed found some more occurrences of this
bashism -- and now I also remember from where that code originates:

Our default.script is mainly based on the scripts in busybox'
examples/udhcpc/ directory. Those are though not part of the binary
packages as we ship our own default.script.

Will send an appropriate patch for the example scripts to upstream,

Hope to find time to create the new patches either late this evening
or tomorrow.

		Regards, Axel
 ,''`.  |  Axel Beckert <abe@debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5

Reply to: