[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#569222: marked as done (risky use of mount from a random partition)

Your message dated Tue, 23 Feb 2010 19:07:31 +0000
with message-id <E1Nk06V-00067M-57@ries.debian.org>
and subject line Bug#569222: fixed in os-prober 1.36
has caused the Debian Bug report #569222,
regarding risky use of mount from a random partition
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

569222: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=569222
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: os-prober
Severity: normal
Tags: security

To mount a /boot partition, os-prober uses the mount binary from the
linux system it is probing. There's a possible security risk here.
Imagine if a compromised system is being reinstalled using a new drive,
and the compromised drive is still connected. An attacker who wanted to
target d-i could arrange for mount to copy itself over to /target when
run. Or a virus, not targeting d-i at all, could infect /target.

r50221 | cjwatson | 2007-11-22 13:16:50 -0500 (Thu, 22 Nov 2007) | 2 lines

* Try finding a LABEL/UUID-capable /bin/mount in $tmpmnt as well as in

I'm wondering what was the rationalle for needing to do that, and why
does the code use the mount from the system being probed, in *preference*
to the one in /target? Perhaps the idea was that a distribution's fstab
might use special features that are only available with its version of
mount, if so I hope that Debian's mount has caught up..?

Also, since we have a udeb containing libblkid, perhaps it's time to
spend the 100k of ram to have os-prober-udeb depend on a mount-udeb
and remove this hack. IIRC this is the last place where d-i runs
binraries from /target or elsewhere w/o chrooting, which has caused
other problems before.

-- System Information:
Debian Release: squeeze/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 2.6.31-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

see shy jo

Attachment: signature.asc
Description: Digital signature

--- End Message ---
--- Begin Message ---
Source: os-prober
Source-Version: 1.36

We believe that the bug you reported is fixed in the latest version of
os-prober, which is due to be installed in the Debian FTP archive:

  to main/o/os-prober/os-prober-udeb_1.36_amd64.udeb
  to main/o/os-prober/os-prober_1.36.dsc
  to main/o/os-prober/os-prober_1.36.tar.gz
  to main/o/os-prober/os-prober_1.36_amd64.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 569222@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Otavio Salvador <otavio@debian.org> (supplier of updated os-prober package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA256

Format: 1.8
Date: Tue, 23 Feb 2010 15:50:17 -0300
Source: os-prober
Binary: os-prober-udeb os-prober
Architecture: source amd64
Version: 1.36
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Otavio Salvador <otavio@debian.org>
 os-prober  - utility to detect other OSes on a set of drives
 os-prober-udeb - utility to detect other OSes on a set of drives (udeb)
Closes: 547382 563825 569222 569229 569235
 os-prober (1.36) unstable; urgency=low
   [ Colin Watson ]
   * Suppress tedious fd leak warnings from LVM tools.
   [ Frans Pop ]
   * Drop support for the discontinued lpia architecture.
   [ Christian Perrier ]
   * Properly quote variable in os-probes/mounted/x86. Thanks
     to Fabian Greffrath for the patch. Closes: #563825
   [ Otavio Salvador ]
   * Applied patch from Brad Jorsch <anomie@users.sourceforge.net> to
     properly detect Windows' recovery partitions. Closes: #547382
   [ Joey Hess ]
   * Load btrfs module if available.
   * Fix arbitrary code execution via eval. Closes: #569229
   * Tighten up quoting of shell variables overall.
   * Avoid ever running mount command from filesystems being probed.
     Closes: #569222
   * Avoid leaving a temporary mountpoint behind when exiting
     in some exceptional conditions. Closes: #569235
 7f0409b13570ce3de6d7601c83e6f9885e5c738d 1521 os-prober_1.36.dsc
 b915d0634cdc3c399dd90f81beb9c831b237e104 21651 os-prober_1.36.tar.gz
 cccf4d0ac82175838015e587d343ace3cacc9d62 12718 os-prober-udeb_1.36_amd64.udeb
 43691c6ba074341b9866aa3d2a98680dc6c4adb3 22262 os-prober_1.36_amd64.deb
 99bf1c0181063fba98ac5a67515733670144a741501364cfe6fb2a6d2c275fbc 1521 os-prober_1.36.dsc
 6343c84c959c192675e205d45f896870e5131bd228fca7a4d162a04c139f41b8 21651 os-prober_1.36.tar.gz
 f506245995b57c1eaf87e60d30c2e92eb871c1eb96918b5de748baeed22ea158 12718 os-prober-udeb_1.36_amd64.udeb
 6d85637077c360df24ccdcd90aed703a3851da183bc2d178c70b5cf514b391ce 22262 os-prober_1.36_amd64.deb
 ccec4cf6b3d1b9481af233df735230c9 1521 debian-installer optional os-prober_1.36.dsc
 51a442eff91b77e1b394c1b81e32462f 21651 debian-installer optional os-prober_1.36.tar.gz
 373d3d28436c5b46305fa51b8c18aeca 12718 debian-installer optional os-prober-udeb_1.36_amd64.udeb
 53c840aa326e62068020ca3a7a56e80f 22262 utils extra os-prober_1.36_amd64.deb
Package-Type: udeb

Version: GnuPG v1.4.10 (GNU/Linux)


--- End Message ---

Reply to: