[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#567182: gcc: Please add libgcc1-udeb for Debian Installer



----------  Forwarded Message  ----------
From: Matthias Klose <doko@debian.org>

On 27.01.2010 21:03, Frans Pop wrote:
> Please consider the attached patch which adds a udeb for libgcc1
> containing only libgcc_s.so.1. That file is needed for the (directfb
> based) graphical installer because of pthread_cancel().

The patch itself looks ok, some other questions:

  - did you consider building the udeb from a separate source package,
    build-depending on gcc-4.4-source? This way you don't need to copy
    the file, and you don't need to add additional constraints for freezes
    on the gcc-4.4 package. You could even copy the whole packaging and
    conditionalize on the source package name for this new source package
    to minimize the maintainance effort and get the updates/patches.

    With --enable-languages=c --disable-bootstrap, the additional build
    time penalty is the extra build of a one stage compiler for gcc.

  - you don't need the package for m68k/hppa yet, but if you do build
    for every architecture anyway, please don't build the package for
    these archs, but libgcc2, libgcc4, and libgcc6 udebs.

  - the patch should be prepared for gcc-4.5 as well.

If there are additional constraints for uploads of the gcc-4.4 source 
package during freeze times, I would prefer the approach to build the 
udeb's from a separate source.

   Matthias
-------------------------------------------------------


Reply to: