[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Avoiding display of console-setup dialogs during base-installation



On Wed, Nov 18, 2009 at 08:38:28PM +0100, Frans Pop wrote:
> On Wednesday 18 November 2009, Anton Zinoviev wrote:
> > On Sun, Nov 15, 2009 at 06:35:50PM +0100, Frans Pop wrote:
> > > I've just committed the following patch for kbd-chooser (which is
> > > currently responsible for installing console-setup). The patch sets
> > > the seen flag for the keyboard variant debconf question to avoid its
> > > display during base-installer.
> >
> > Just for the record I'd like to say that I don't agree with this change.
> > A better solution is to make console-setup ask this question with low
> > priority (which is not difficult).
> 
> What exactly do you consider to be the downside of the current solution?

1. It doesn't seem right to omit completely such an important question.  

2. In Ubuntu console-setup doesn't omit this question but asks it with 
   lower priority and nobody has complained.

3. Maybe I am wrong, but during the discussion about the question about 
   /dev/tty[1-6] I had the impression that the people are agains the 
   questions of low priority not because they are bad for the users but 
   because they make the testing of the installer more boring.

4. Playing with the seen flag can cause unexpected bugs in some future 
   version of console-setup.  (Or maybe even in the current version?  See 
   #536683.)

5. In some cases this is simply wrong.  In Bulgaria almost everybody 
   uses phonetic layout but if the variant question is omited console-setup 
   will configure the bds layout which is totaly different.

> You're of course welcome to post the alternative for review.

A very simple one:

Index: debian/keyboard-configuration.config
===================================================================
--- debian/keyboard-configuration.config	(revision 61355)
+++ debian/keyboard-configuration.config	(working copy)
@@ -708,7 +708,7 @@
     old_xkbvariant="$XKBVARIANT"
     XKBVARIANT=''
     old_layout_priority=$layout_priority
-    layout_priority=medium
+    layout_priority=low
     case "$di_keymap" in
 	be2) XKBLAYOUT="be";;
 	bg) XKBLAYOUT="us,bg";;

Anton Zinoviev


Reply to: