Quoting Frans Pop (elendil@planet.nl):
> The existing templates for the four main questions in localechooser all
> have problems: they cause Lintian warnings and don't really help the
> user with what he's doing.
Thanks for working on this. It was on my TODO list for a while as I
found quite strange to enfore some style improvements in many packages
through Smith reviews...and omit to "correct" thos I use in D-I..:)
> --- a/packages/localechooser/debian/localechooser.templates-in
> +++ b/packages/localechooser/debian/localechooser.templates-in
> @@ -11,9 +11,8 @@ Template: debian-installer/locale
> Type: select
> Choices: ${LOCALELIST}
> # :sl2:
> -_Description: Choose a locale:
> - Based on your language and country choices, the following locale
> - parameters are supported.
> +_Description: System locale:
> + Select the default locale for the installed system.
I'd just recommend "Please select" which is the style we generally
push in dle reviews (avoid imperative form).
Apart from that, fine by me.
>
> Template: debian-installer/fallbacklocale
> Type: select
> @@ -49,9 +48,9 @@ Choices-C: ${CODES}
> Choices: ${NAMES_EN}
> Choices-en.UTF-8: ${NAMES_BOTH}
> Default: en
> -Description: Choose a language:
> - Please choose the language used for the installation process. This
> - language will be the default language for the final system.
> +Description: Language:
> + Choose the language to be used for the installation process. The selected
> + language will also be the default language for the installed system.
Ditto....
>
> Template: localechooser/translation/none-yet
> Type: note
> @@ -141,16 +140,25 @@ Type: select
> # :sl1:
> __Choices: ${SHORTLIST}, other
> # :sl1:
> -_Description: Choose a country, territory or area:
> - Based on your language, you are probably located in one of these countries
> - or regions.
> +_Description: Country, territory or area:
> + Select the country where you live. The selection will be used for example to
> + select a default locale and time zone.
> + .
> + Choose "other" if your country is not listed.
That one is more tricky. Using "where you live" implicitely assumes
that the user installing the system is the one "owning" the machine,
which is not well suited in all cases. Also, the user might be living
somewhere but installing the machine elsewhere. Of course, what
matters here is probably more the place where the machine is
living..:-)
The former template had the same "problem" of course.
Please select the country where the installed system is used. The
selection will set the default locale and time zone.
Choose "other" to get the full list of countries.
> Template: localechooser/supported-locales
> Type: multiselect
> Choices: ${LOCALELIST}
> # :sl2:
> -_Description: Choose other locales to be supported:
> - You may choose additional locales to be installed from this list.
> +_Description: Additional locales:
> + A locale determines character encoding and contains information on e.g.
> + currency, date format and alphabetical sort order. Based on the selected
> + language and country, the default locale selected for the installed system
> + is '${LOCALE}'.
> + .
> + If you wish to use a different default or to also have other locales available,
> + you may choose additional locales to be installed. If you are unsure it is
> + best to simply stick with the default.
After discussions in dle, we concluded (mostly others than me as I'm
of course polluted by Latin) that "latin" abbreviations such as "e.g."
are not highly wished in English. "such as" would then be recommended.
Apart from that, everything is fine, except maybe the length of the
two paragrpahs, that takes a lot of spaces and leaves few romm for the
list on 80x25 systems.
> --- a/packages/localechooser/mktemplates.continents
> +++ b/packages/localechooser/mktemplates.continents
> @@ -100,6 +100,9 @@ foreach my $region (@known_regions) {
> print TOUT "#flag:partial\n";
> print TOUT "__Choices: ", join(", ", @countries), "\n";
> print TOUT "_Description: ", gettext("Choose a country, territory or area:"), "\n";
> + print TOUT " ", gettext("Select the country where you live. The selection will be used for example to select a default locale and time zone."), "\n";
> + print TOUT " .\n";
> + print TOUT " ", gettext("Choose \"other\" if your country is not listed."), "\n";
> print TOUT "\n";
> } else {
> print STDERR "I: skipping region $region: no associated countries in $regionmap\n";
Of course, sams suggestions than those I made for the regular template.
> @@ -111,8 +114,8 @@ print TOUT "Template: localechooser/continentlist\n";
> print TOUT "Type: select\n";
> print TOUT "#flag:partial\n";
> print TOUT "__Choices: ", join(", ", @regions), "\n";
> -print TOUT "_Description: ", gettext("Choose a continent or region:"), "\n";
> -print TOUT " ", gettext("The continent or region in which the desired country is located."), "\n";
> +print TOUT "_Description: ", gettext("Continent or region:"), "\n";
> +print TOUT " ", gettext("Select the continent or region in which the country where you live is located."), "\n";
"Please select the continent or region in which the country this
system is used is located."
Attachment:
signature.asc
Description: Digital signature