Bug#476184: os-prober: Mounted partitions after running update-grub

[Felix Zielcke <fzielcke@z-51.de>]

Am Dienstag, den 18.08.2009, 12:39 +0200 schrieb Frans Pop:
> On Tuesday 18 August 2009, Felix Zielcke wrote:
> > Am Dienstag, den 18.08.2009, 06:27 -0300 schrieb Otavio Salvador:
> > > On Fri, Jul 31, 2009 at 4:33 PM, Felix Zielcke<fzielcke@z-51.de> 
> wrote:
> > > > Any chance that the Ubuntu patch gets included in Debian's
> > > > os-prober? On Launchpad there aren't any reports open related to
> > > > this.
> > >
> > > I think it would be nice if you could prepare the patch and post on
> > > this bug report so we could review it.
> >
> > Here it is.
> 
> What is the rationale behind this patch? How would you describe this in 
> the changelog?

Ubuntu's changelog says:

    - If any umount fails, sleep for five seconds and try again, up to three
      times; it seems that occasionally desktop automounting systems grab
      the device at just the wrong time.

> Are the '|| true' statements after the calls to repeat_umount() really 
> needed? I don't see anywhere where that function would return an error.

Colin made it, maybe he can explains this.
I think the break should be a `return 0' and at the end of the function
a `return 1' so that this would make sense.

-- 
Felix Zielcke
Proud Debian Maintainer