Re: [PATCH 3/4] Add support for producing disks with (optional) extra variants.

[Ian Campbell <ijc@hellion.org.uk>]

On Fri, 2009-08-07 at 16:08 +0200, Frans Pop wrote:
> (No need to CC me on replies.)

Sorry about that.

> On Friday 07 August 2009, Ian Campbell wrote:
> >  show_usage() {
> > -       echo "Usage: $(basename $0) [-d gnome|kde|lxde|xfce|light|all] BC|NETINST|CD|DVD [<ARCH> ...]"
> > +       echo "Usage: $(basename $0) [-d gnome|kde|lxde|xfce|light|all] [-v VARIANTS] BC|NETINST|CD|DVD [<ARCH> ...]" }
> 
> This line is getting too long now. Suggest changing it to:
> echo "Usage: $(basename $0) [OPTIONS] BC|NETINST|CD|DVD [<ARCH> ...]"
> echo "  Options:"
> echo "     -d gnome|kde|lxde|xfce|light|all : desktop variant (task) to use"
> echo "     -v <variant> : ..."
> echo "     -h help"

ACK.
 
> > @@ -25,7 +25,8 @@ if [ $# -eq 0 ]; then
> >  fi
> >  
> >  desktop=
> > -while getopts d:h OPT ; do
> > +VARIANTS=
> > +while getopts d:hV: OPT ; do
> 
> Why capital V instead of lower case v as shown in usage?

I started with one and changed my mind to use the other. I think I
intended to switch completely to -V in order to leave -v free for the
more common use of "verbose" if that ever became useful or necessary
(maybe unlikely).

Since fixing up the usage spans multiple patches I'll repost the entire
series with all the feedback so far.

Ian.
-- 
Ian Campbell

Marriage is the waste-paper basket of the emotions.