[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFC] rootcmd for d-i Makefile



Hi all,

I've been using this change locally for a few days. It
allows to just do make as a regular user without having
to remember to call it with fakeroot.

--- a/installer/build/Makefile
+++ b/installer/build/Makefile
@@ -95,9 +95,13 @@ include config/dir
 export KEYRING
 export KERNELVERSION
 
+ifneq ($(shell id -u),0)
+  ROOTCMD ?= fakeroot
+endif
+
 # Useful command sequences
 define submake
-  $(MAKE) --no-print-directory
+  $(ROOTCMD) $(MAKE) --no-print-directory
 endef
 
This likey doesn't cover all scenarios, e.g. I think 
there would be a problem if some parts expect the fakeroot 
to persist between different submake invokations.

That said, it works for me in the simple cases I frequently
use (build_{netboot,monolithic}, rebuild_netboot, clean_\
netboot, reallyclean) and does save me some typing.

What you do you guys think?

	Max


Reply to: