[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#536820: please add scratchbox2 variant



On Sun, Jul 19, 2009 at 08:41:53PM -0300, Otavio Salvador wrote:
> > Also, I think for low-volume projects such as debootstrap, it is faster to
> > just fix up the whitespaces while commiting and tell the contributor
> > to take a close look at whitespace issues before sending the next patch.

> Well I somewhat agree with that. I've reported it to you so you could
> look at it and fix it but in case you did not found the time for that
> I'd do that.

> BTW the thing I had noticed you got fixed.

So you are happy with the whitespace now?

> @@ -52,6 +52,8 @@
> 
>      if doing_variant fakechroot; then
>          setup_devices_fakechroot
> +    elif doing_variant schratchbox; then
> +        true

> Typo? :-)

Hrmh. In fact this shows that that codepath is actually not
needed then :) Thanks for spotting it. We still need the /proc
path since we can't mount in scratchbox. updated patch attached.

> I'll wait few days for comments from others before commit it.

thanks



Reply to: