[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Online help

On Mon, Jun 29, 2009 at 01:11:27PM +0100, Colin Watson wrote:
> Index: src/modules/db/mysql/create.sql
> ===================================================================
> --- src/modules/db/mysql/create.sql	(revision 59150)
> +++ src/modules/db/mysql/create.sql	(working copy)
> @@ -33,6 +33,7 @@
>  	choices		CHAR(255),
>  	description	CHAR(80),
>  	ext_description	CHAR(255),
> +	help		CHAR(80),
>  	modified	TIMESTAMP,
>  	PRIMARY KEY(id),
>  	KEY idx_Templates_tag(tag)

Otavio asked on IRC why this is CHAR(80) rather than CHAR(255). The
answer is that it's a tag, and tags are CHAR(80) elsewhere; however,
this should really be help_id INT UNSIGNED and be a reference to another
row. I've made that change locally.

(Not that this really matters since the mysql database backend is
basically moribund and I didn't add help support to it properly, but
just in case somebody wants to fix it up one of these days ...)

Colin Watson                                       [cjwatson@debian.org]

Reply to: