[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#527306: use busybox tar, not tar from live system



Joey Hess wrote:

> Removing the 'chroot .' should be all that's necessary, plus testing of
> course.

You need to remove the "--exclude=target" bit too, as that's not supported
in busybox tar. (This was only a paranoid measure anyway.)

Patch attached for clarity. Tested using d-i daily i386 build.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org
       `-
From 9446c0fcb7fbcccad7b02c9b9b45eb3c60b924c4 Mon Sep 17 00:00:00 2001
From: Chris Lamb <lamby@debian.org>
Date: Mon, 11 May 2009 00:55:22 +0100
Subject: [PATCH] busybox-udeb now supports tar creation, so don't use tar from the live system. (Closes: #527306)

---
 packages/live-installer/debian/changelog |    7 +++++++
 packages/live-installer/debian/postinst  |    9 +--------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/packages/live-installer/debian/changelog b/packages/live-installer/debian/changelog
index a8898f5..69918d2 100644
--- a/packages/live-installer/debian/changelog
+++ b/packages/live-installer/debian/changelog
@@ -1,3 +1,10 @@
+live-installer (9) UNRELEASED; urgency=low
+
+  * busybox-udeb now supports tar creation, so don't use tar from the live
+    system. (Closes: #527306)
+
+ -- Chris Lamb <lamby@debian.org>  Mon, 11 May 2009 00:12:50 +0100
+
 live-installer (8) unstable; urgency=low
 
   [ Updated translations ]
diff --git a/packages/live-installer/debian/postinst b/packages/live-installer/debian/postinst
index e1eab1b..bbcb2c4 100755
--- a/packages/live-installer/debian/postinst
+++ b/packages/live-installer/debian/postinst
@@ -40,15 +40,8 @@ install_live_system () {
 		COUNT=0
 		OLD_IFS=$IFS
 		mkdir -p /target
-		# use tar from inside the live filesystem to create
-		# the tarball, because busybox tar in d-i does not 
-		# support creating tarballs.
-		# 
-		# The --exclude is a paranoia measure, in case this program
-		# is running from the toplevel of a live filesystem,
-		# which is not normally the case.
 		exec 4>&0
-		chroot . tar c . --exclude=target | \
+		tar c . | \
 		(chdir /target && tar xv) | \
 		(
 			while read line; do
-- 
1.6.3

Attachment: signature.asc
Description: PGP signature


Reply to: