[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#507372: marked as done (cdebconf-newt-udeb: does not show enough choices for long descriptions)

Your message dated Sun, 05 Apr 2009 21:02:19 +0000
with message-id <E1LqZTv-0007ce-NV@ries.debian.org>
and subject line Bug#507372: fixed in cdebconf 0.140
has caused the Debian Bug report #507372,
regarding cdebconf-newt-udeb: does not show enough choices for long descriptions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

507372: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=507372
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: cdebconf-newt-udeb
Severity: minor
Tags: patch

On Mon, Nov 24, 2008 at 09:12:58PM +0100, Ferenc Wagner wrote:
> I've pulled the netboot Xen variant and did a paravirtual
> installation.  It went all right, but I noticed a mysterious empty box
> on the APT setup screen: see http://apt.niif.hu/apt-config.png above
> the <Continue> button.  Is that maybe a degenerated scrollbar, where
> volatile is hiding?  It isn't included in sources.list after
> installation.  I can't test it until tomorrow, but it's unfortunate
> either way...

Indeed, the minimum size requirement for select/multiselect questions
was not computed maximum number of lines that could be used for the

The attached patch fix this issue.  I have run an installation through
the end without any problem with the patch applied.

Jérémy Bobbio                        .''`. 
lunar@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
diff --git a/packages/cdebconf/src/modules/frontend/newt/newt.c b/packages/cdebconf/src/modules/frontend/newt/newt.c
index 71dd5c3..4137ff7 100644
--- a/packages/cdebconf/src/modules/frontend/newt/newt.c
+++ b/packages/cdebconf/src/modules/frontend/newt/newt.c
@@ -118,6 +118,7 @@ struct newtColors newtAltColorPalette = {
 typedef int (newt_handler)(struct frontend *obj, struct question *q);
 static void newt_progress_stop(struct frontend *obj);
+static char *get_full_description(struct frontend *obj, struct question *q);
 #include "cdebconf_newt.h"
@@ -255,11 +256,11 @@ min_window_height(struct frontend *obj, struct question *q, int win_width)
     int height = 3;
     char *type = q->template->type;
-    char *q_ext_text;
+    char *full_description;
-    q_ext_text = q_get_extended_description(obj, q);
-    if (q_ext_text != NULL)
-        height = cdebconf_newt_get_text_height(q_ext_text, win_width) + 1;
+    full_description = get_full_description(obj, q);
+    if (full_description != NULL)
+        height = cdebconf_newt_get_text_height(full_description, win_width) + 1;
     if (strcmp(type, "multiselect") == 0 || strcmp(type, "select") == 0)
         height += 4; // at least three lines for choices + blank line
     else if (strcmp(type, "string") == 0 || strcmp(type, "password") == 0)

Attachment: signature.asc
Description: Digital signature

--- End Message ---
--- Begin Message ---
Source: cdebconf
Source-Version: 0.140

We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:

  to pool/main/c/cdebconf/cdebconf-gtk-udeb_0.140_amd64.udeb
  to pool/main/c/cdebconf/cdebconf-newt-udeb_0.140_amd64.udeb
  to pool/main/c/cdebconf/cdebconf-priority_0.140_all.udeb
  to pool/main/c/cdebconf/cdebconf-text-udeb_0.140_amd64.udeb
  to pool/main/c/cdebconf/cdebconf-udeb_0.140_amd64.udeb
  to pool/main/c/cdebconf/cdebconf_0.140.dsc
  to pool/main/c/cdebconf/cdebconf_0.140.tar.gz
  to pool/main/c/cdebconf/cdebconf_0.140_amd64.deb
  to pool/main/c/cdebconf/libdebconfclient0-dev_0.140_amd64.deb
  to pool/main/c/cdebconf/libdebconfclient0-udeb_0.140_amd64.udeb
  to pool/main/c/cdebconf/libdebconfclient0_0.140_amd64.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 507372@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Otavio Salvador <otavio@debian.org> (supplier of updated cdebconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Sun, 05 Apr 2009 17:36:15 -0300
Source: cdebconf
Binary: cdebconf libdebconfclient0 libdebconfclient0-dev cdebconf-udeb cdebconf-priority libdebconfclient0-udeb cdebconf-slang-udeb cdebconf-newt-udeb cdebconf-text-udeb cdebconf-gtk-udeb
Architecture: source all amd64
Version: 0.140
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Otavio Salvador <otavio@debian.org>
 cdebconf   - Debian Configuration Management System (C-implementation)
 cdebconf-gtk-udeb - Gtk+ frontend for Debian Configuration Management System (udeb)
 cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
 cdebconf-priority - Change debconf priority (udeb)
 cdebconf-slang-udeb - S-Lang frontend for Debian Configuration Management System (udeb)
 cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
 cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
 libdebconfclient0 - Debian Configuration Management System (C-implementation)
 libdebconfclient0-dev - Development files for cdebconf
 libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 343119 507372 508042
 cdebconf (0.140) unstable; urgency=low
   [ Frans Pop ]
   * Remove myself as uploader.
   [ Nicolas François ]
   * src/template.c (remove_newlines): Fix the removal of trailing
     newline for descriptions ending with a verbatim block. This helps
     optimizing the screen usage in the newt frontend.
   * Fix the computation and usage of the window's height. If the height is not
     computed correctly, the newt frontend may decide to put the input box and
     the explanatory text on the same window, but the text will overlap on the
     input box, which renders the input impossible.
     Closes: #508042, #507372, #343119
   * Optimize the screen usage (2 lines) in the newt frontend when a
     description and select menu are on the same windows or when a big select
     menu is displayed on its own window.
   [ Updated translations ]
   * Galician (gl.po) by marce villarino
   * Hindi (hi.po) by Kumar Appaiah
   * Italian (it.po) by Milo Casagrande
   * Slovak (sk.po) by Ivan Masár
 e1d538bb40f91c1013558482c4ea51239bdb1359 1323 cdebconf_0.140.dsc
 92ec686b31f66f201926ec78e0acf7cdc1100765 313815 cdebconf_0.140.tar.gz
 8104d1d3ede0ce33cd2e4dad7de76068222d7cf1 2822 cdebconf-priority_0.140_all.udeb
 d413ec4f35aa4d8f27f5617a4e21d5c512277705 174570 cdebconf_0.140_amd64.deb
 dd3b2300d0a5a05f22643a2aca0127d2828d48dd 38778 libdebconfclient0_0.140_amd64.deb
 30ed5e1e266672d47a091bf0337e759abd0646d0 43036 libdebconfclient0-dev_0.140_amd64.deb
 a65fa8fb4100e16a6eb49ca052a012a49a1fdec0 82234 cdebconf-udeb_0.140_amd64.udeb
 103cb1b7ab5d77a4d2d4f840011309d63c5fec5a 3262 libdebconfclient0-udeb_0.140_amd64.udeb
 321762a40ef0596a2a5b275072b2606c613361d3 19118 cdebconf-newt-udeb_0.140_amd64.udeb
 0b5d2523c3ea3c7fb9e64e1567f91a094b4c70c7 20380 cdebconf-text-udeb_0.140_amd64.udeb
 64961d73fea57cdcf7318d4c88ca434f006bcd25 30878 cdebconf-gtk-udeb_0.140_amd64.udeb
 22175fa91ae62f5ededde79033954a263df1e80b36284bb5a13f223c0ab05bdf 1323 cdebconf_0.140.dsc
 6d24a4579a30fd8ae967f25672c5d876f6d6af348fab4c674aa42bc9573011ac 313815 cdebconf_0.140.tar.gz
 6ae1b826b7d27c7bc3cd16ed93d250d4ff03e46bc93efab368cee5b1ec94cc55 2822 cdebconf-priority_0.140_all.udeb
 d426a04861a5886ddc435431a4c44d01f64918dffb09a8deb635d65d125b20fe 174570 cdebconf_0.140_amd64.deb
 2ed47c5988190a0fef40f3a14e787a2919e21d58dcb01058970ce60325ad60bf 38778 libdebconfclient0_0.140_amd64.deb
 4d5ba7db3b454c921ffb4add913b0de71ca1834c656fb98d45681093bcc924a4 43036 libdebconfclient0-dev_0.140_amd64.deb
 82036183c1d2af00ac7c8c27345c449ff464c7aef5a4d6eee00c8a2a64a3c18a 82234 cdebconf-udeb_0.140_amd64.udeb
 da7247420be92a44f66ec802d7ab52e307422e34232d157a22571b9f3fa58b4b 3262 libdebconfclient0-udeb_0.140_amd64.udeb
 76d0ded07e6d0c10f9dec2add98a4c2d007624fd7e9c5676382d9dba61b37e12 19118 cdebconf-newt-udeb_0.140_amd64.udeb
 4bf06ff638242780b951502d71da5ea2d41ddc965fa89d518316cc4baf4a54d3 20380 cdebconf-text-udeb_0.140_amd64.udeb
 62255071b40239641192645a6671687999c7a48349ff3a1b5762e27e8bf054d8 30878 cdebconf-gtk-udeb_0.140_amd64.udeb
 e4485ed2da9410c7e8f9c635fa17fd9c 1323 utils optional cdebconf_0.140.dsc
 8f18f7ae77a8db379628ee27700dcd6d 313815 utils optional cdebconf_0.140.tar.gz
 31ce54b2a7e33d7a38f37e780618287a 2822 debian-installer standard cdebconf-priority_0.140_all.udeb
 002970668c21c5fa505eaf97ce723560 174570 utils extra cdebconf_0.140_amd64.deb
 c917a196d42f95bf5052ad5bab69d9cc 38778 libs optional libdebconfclient0_0.140_amd64.deb
 29ec525527276edd337d40feb585b45a 43036 libdevel optional libdebconfclient0-dev_0.140_amd64.deb
 da464c439f8590267648814af8f799a8 82234 debian-installer standard cdebconf-udeb_0.140_amd64.udeb
 7f10ed0af99af9dbc2b2abcb6b945727 3262 debian-installer optional libdebconfclient0-udeb_0.140_amd64.udeb
 16b959be8ade1b5b7025a8314ca2def2 19118 debian-installer optional cdebconf-newt-udeb_0.140_amd64.udeb
 55b782b9feb428b154018c1488e01d65 20380 debian-installer optional cdebconf-text-udeb_0.140_amd64.udeb
 b2f04560a118b9da1b7f73d7237871da 30878 debian-installer optional cdebconf-gtk-udeb_0.140_amd64.udeb
Package-Type: udeb

Version: GnuPG v1.4.9 (GNU/Linux)


--- End Message ---

Reply to: