Re: [PATCH 12/15] [linux-kernel-di-amd64-2.6] crypto-core-modules: dropped
On Mon, Mar 23, 2009 at 7:38 PM, Frans Pop <elendil@planet.nl> wrote:
> On Monday 23 March 2009, Ian Campbell wrote:
>> On Mon, 2009-03-23 at 23:05 +0100, Frans Pop wrote:
>> > On Monday 23 March 2009, Ian Campbell wrote:
>> > > IIRC I was asked to add direct to i386 instead of adding to kernel
>> > > wedge. Maybe that was because i386 was the only one back then
>> > > though and for two arches kernel-wedge makes sense. The only other
>> > > (currently) potential arch is ia64 though.
>> >
>> > IMO adding them to kernel wedge does not make sense as long as that
>> > results in the modules being added in generic kernel udebs (such as
>> > nic-modules) for arches where they are sure to be unused.
>>
>> The modules aren't even built on architectures where Xen is not
>> supported or enabled in the kernel .config, so there is no danger of
>> them getting into any udebs where they don't belong. The modules are
>> marked as optional for this reason, see for example the 486 kernel
>> which doesn't have Xen enabled in it, and as expected there are no Xen
>> modules in any 486 udeb despite them being present in the 386 specific
>> udeb lists.
>
> You mentioned IA64. As long as we have no D-I support for Xen for that,
> adding the udebs in kernel-wedge would result in them being uselessly
> being included there.
>
> Also, for i386 you have the split between the 486 kernel and the Xen
> kernel for D-I, but that's not true for amd64. So for amd64 the Xen
> modules would end up in all images.
Sure we really care about them being included on amd64 images?
amd64 machines are powerful enough to the increase of memory
due those module be mostly ignored and about ia64 I do believe
we'll end up supporting them once kernel does it properly.
I see i386 case mostly a workaround due our backward compatibility
for older machines. I do agree that this is really important, so
makes sense to provde a specific image for xen. This isn't the case
for amd64 it doesn't makes sense for me.
Only con I see about having it in all amd64 images is that we'll
need to be carefully how to proper document it. Besides that, I
see no problem with that.
Kind regards,
--
Otavio Salvador O.S. Systems
E-mail: otavio@ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Reply to: