Bug#515607: partman-auto-lvm: ask how much VG space to use
On Mon, Feb 16, 2009 at 03:47:21PM +0100, Frans Pop wrote:
> On Monday 16 February 2009, Colin Watson wrote:
> > The attached patch (against the Ubuntu package, but it doesn't make
> > much difference) implements this. I've tested it and it seems to be
> > working rather well. However, I'm interested in other people's thoughts
> > before going ahead and committing it to d-i proper.
>
> I find the dialog rather misleading. You say "amount of *disk space* to be
> used for guided partitioning", but what you do (IIUC) is only to leave
> part of the *VG* unused: you still create a VG that fills the whole disk.
I meant the VG.
> The "or if you add more disks" also makes no sense in the context of your
> patch.
Sure it does; if you add more disks, you can add new physical volumes on
them and easily extend your volume group. This is pretty standard LVM
operation.
> I wonder if it would not be better to allow users to specify to leave a
> _partition_ of a certain size unused. That would also make it usable for
> non-LVM guided partitioning and is a much better match for the
> description in your template.
That would be much less useful. If you're using LVM you generally want
to just use LVM (with the exception of stuff like a /boot partition or /
outside LVM or whatever), and generally it's much more convenient to
just stick all unused disk space into the volume group. That doesn't
necessarily mean that you want it all to be allocated to logical volumes
up-front.
--
Colin Watson [cjwatson@debian.org]
Reply to: