Re: Revert r56948? (console-setup: fix keymap reduction)
On Sat, Jan 31, 2009 at 10:13:07PM +0200, Anton Zinoviev wrote:
> On Sat, Jan 31, 2009 at 07:44:59PM +0200, Anton Zinoviev wrote:
> > I would like to revert r56948 unless there is something I don't see. As
> > far as I can remember this change increases the size of the precompiled
> > keymaps by many times.
>
> I tested this. With the new xkb data files the change in size is
> insignificant - for the standard pc keyboards before r56948 it was 94K
> and after r56948 it is 96K.
Indeed; the difference should be roughly linear in the number of keymaps
with different sets of mapped keys, which is small.
> > I think r56948 makes only the following improvement:
>
> Actualy it seems at present r56948 makes no improvement.
At the time, it definitely fixed
https://bugs.launchpad.net/ubuntu/+source/console-setup/+bug/74375. I
think the XKB keymaps may have changed since then in such a way as to
perturb things such that this is no longer so easily reproducible,
although it might still be possible with some reduced set.
> In order to make r56948 do what I think it is supposed to do one has
> to change also another line in kbdcompiler (I haven't tested this):
>
> --- kbdcompiler 2009-01-31 21:34:04.360510128 +0200
> +++ kbdcompiler2 2009-01-31 22:06:26.328010042 +0200
> @@ -170,7 +170,7 @@
> my $mink1 = '';
> my $mink2 = '';
> my $minsub = 10000000;
> - for $k1 (keys %kmaps, '') {
> + for $k1 ('', keys %kmaps) {
> for $k2 (keys %kmaps) {
> next if ($k1 eq $k2);
> if ($k1 eq '') {
I have to admit that I'm not sure I can follow what effect that will
have? Maybe I need more coffee ...
--
Colin Watson [cjwatson@debian.org]
Reply to: