[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#442382: Updated multipath patch for grub-legacy

tags 442382 + patch

On Sat, Jan 31, 2009 at 09:16:27PM +0100, Robert Millan wrote:
> tags 442382 - patch
> thanks
> On Thu, Jan 29, 2009 at 04:27:54PM +0100, Guido Günther wrote:
> > +--- a/lib/device.c.org	2009-01-29 13:31:54.000000000 +0100
> > ++++ b/lib/device.c	2009-01-29 13:38:48.000000000 +0100
> This is not the right place.  We use grub-mkdevicemap for all new device types,
> please modify that instead.
Please read the patch carefully. I know that we use grub-mkdevicemap for
device map generation. The important part of the patch is the last hunk.
Independent of the probing (which we currently don't need in d-i, since
we use the workaround dmraid uses) we need to pick the right *partition*
name [1]. The rest of the patch is just to bring it in line with e.g.
cciss, we keep the probing code around for that too.
Anyways, I will stop bothering you now, it's just too tiresome and we
have workarounds.
 -- Guido

[1] and I'd accept any criticism that the code there is far too generic
and might incorrectly match LVM volumes but that didn't come up since
the first verion was posted about 1.5 years ago.

Reply to: